-
Notifications
You must be signed in to change notification settings - Fork 564
Enable building LLVM cross-compilers on Linux #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7ed82bc to
0231327
Compare
| <!-- LLVM --> | ||
| <_LlvmNeeded Condition=" '$(AndroidSupportedTargetAotAbis)' != '' ">yes</_LlvmNeeded> | ||
| <_LlvmCanBuild64 Condition=" '$(HostBits)' == '64' ">yes</_LlvmCanBuild64> | ||
| <_LlvmNeededWindows32></_LlvmNeededWindows32> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why this line and the following two lines are required. If the @Condition fails, they'll default to the empty string/undefined anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's to reset them to a known state. Properties may be set in the environment or msbuild command line and in this case we don't want that to be possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That won't override values set on the command-line. msbuild /p:_LlvmNeededWindows32=Garbage always takes precedence, and is immutable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I didn't know that, oh well.
0231327 to
6add7d1
Compare
Linux doesn't need to build MXE since the distributions we support at this point have mingw packaged and we rely on the packages to provide cross-compilation environment for Windows. Neither does Linux build require the Mono Windows environments to be built. Previously, when one enable the Windows LLVM build the Mono Windows runtime was attempted to build as well. The attempt would fail since some Windows-only libraries required by Mono/libmonodroid aren't available as packages on Linux. This commit disables building of Mono Windows runtimes while making it possible to build the LLVM Windows cross compiler.
6add7d1 to
9d02e7a
Compare
|
The macOS+xbuild PR Build hung on adb attach. :-( It was stuck for nearly 90 minutes. :-( |
|
We had some network issue that caused build failures (Slow network in Cambridge 1CC causing build failures) |
|
build |
2 similar comments
|
build |
|
build |
Linux doesn't need to build MXE since the distributions we support at
this point have mingw packaged and we rely on the packages to provide
cross-compilation environment for Windows. Neither does Linux build
require the Mono Windows environments to be built.
Previously, when one enable the Windows LLVM build the Mono Windows
runtime was attempted to build as well. The attempt would fail since
some Windows-only libraries required by Mono/libmonodroid aren't available
as packages on Linux.
This commit disables building of Mono Windows runtimes while making it
possible to build the LLVM Windows cross compiler.