Skip to content

Conversation

@grendello
Copy link
Contributor

Linux doesn't need to build MXE since the distributions we support at
this point have mingw packaged and we rely on the packages to provide
cross-compilation environment for Windows. Neither does Linux build
require the Mono Windows environments to be built.

Previously, when one enable the Windows LLVM build the Mono Windows
runtime was attempted to build as well. The attempt would fail since
some Windows-only libraries required by Mono/libmonodroid aren't available
as packages on Linux.

This commit disables building of Mono Windows runtimes while making it
possible to build the LLVM Windows cross compiler.

@grendello grendello added enhancement Proposed change to current functionality. full-mono-integration-build For PRs; run a full build (~6-10h for mono bumps), not the faster PR subset (~2h for mono bumps) labels Aug 18, 2017
<!-- LLVM -->
<_LlvmNeeded Condition=" '$(AndroidSupportedTargetAotAbis)' != '' ">yes</_LlvmNeeded>
<_LlvmCanBuild64 Condition=" '$(HostBits)' == '64' ">yes</_LlvmCanBuild64>
<_LlvmNeededWindows32></_LlvmNeededWindows32>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this line and the following two lines are required. If the @Condition fails, they'll default to the empty string/undefined anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to reset them to a known state. Properties may be set in the environment or msbuild command line and in this case we don't want that to be possible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That won't override values set on the command-line. msbuild /p:_LlvmNeededWindows32=Garbage always takes precedence, and is immutable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I didn't know that, oh well.

Linux doesn't need to build MXE since the distributions we support at
this point have mingw packaged and we rely on the packages to provide
cross-compilation environment for Windows. Neither does Linux build
require the Mono Windows environments to be built.

Previously, when one enable the Windows LLVM build the Mono Windows
runtime was attempted to build as well. The attempt would fail since
some Windows-only libraries required by Mono/libmonodroid aren't available
as packages on Linux.

This commit disables building of Mono Windows runtimes while making it
possible to build the LLVM Windows cross compiler.
@jonpryor
Copy link
Contributor

jonpryor commented Aug 21, 2017

The macOS+xbuild PR Build hung on adb attach. :-(

12:05:43 		adb I 08-21 12:05:43 90886 15597543 adb_io.cpp:75] readx: fd=3 wanted=4
# ...and then i killed it...
13:31:17 		Tool /Users/builder/android-toolchain/sdk/platform-tools/adb execution finished.

It was stuck for nearly 90 minutes. :-(

@atsushieno
Copy link
Contributor

We had some network issue that caused build failures (Slow network in Cambridge 1CC causing build failures)

@atsushieno
Copy link
Contributor

build

2 similar comments
@radekdoulik
Copy link
Member

build

@grendello
Copy link
Contributor Author

build

@jonpryor jonpryor merged commit 5033529 into dotnet:master Aug 24, 2017
@grendello grendello deleted the cppsharp-linux branch August 24, 2017 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Proposed change to current functionality. full-mono-integration-build For PRs; run a full build (~6-10h for mono bumps), not the faster PR subset (~2h for mono bumps)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants