Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Add support for tvOS devices in XHarness Helix SDK" commit broke some usages of Helix SDK #7161

Closed
MattGal opened this issue Mar 29, 2021 · 1 comment
Closed

"Add support for tvOS devices in XHarness Helix SDK" commit broke some usages of Helix SDK #7161

MattGal opened this issue Mar 29, 2021 · 1 comment
Assignees
@premun @MattGal
Labels
Detected By - Customer Issue was reported by a customer Ops - First Responder

Comments

@MattGal
Copy link
Member

MattGal commented Mar 29, 2021

@premun FYI.

As seen in dotnet/aspnetcore#31349, it looks like this change fails to correctly resolve the new task assembly it's loading stuff from in some cases; we need to either conditionally not import this task or resolve the correct path to the Arcade SDK DLL.

If this isn't getting more or less instantly fixed, we should revert the commit.
@dougbu dougbu mentioned this issue Mar 29, 2021
Merged
@MattGal MattGal mentioned this issue Mar 29, 2021
Merged
1 task
@MattGal
Copy link
Member Author

MattGal commented Mar 30, 2021

Should be addressed by #7163

@MattGal MattGal closed this as completed Mar 30, 2021
@ilyas1974 ilyas1974 added the Detected By - Customer Issue was reported by a customer label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@premun premun

@MattGal MattGal

Labels
Detected By - Customer Issue was reported by a customer Ops - First Responder
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@premun @MattGal @ilyas1974