Skip to content

Reinstate snapshot-based testing #9072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 5, 2025
Merged

Reinstate snapshot-based testing #9072

merged 7 commits into from
May 5, 2025

Conversation

@RussKie
Copy link
Contributor

@RussKie RussKie commented May 2, 2025 •
edited
Loading

This reverts commit 8b01c53.

Resolves #9024

@RussKie RussKie requested review from eerhardt and radical as code owners May 2, 2025 04:37
@github-actions github-actions bot added the area-integrations Issues pertaining to Aspire Integrations packages label May 2, 2025
@RussKie
Copy link
Contributor Author

RussKie commented May 2, 2025

Full CI run: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1032062&view=results

@RussKie RussKie self-assigned this May 2, 2025
@RussKie
Copy link
Contributor Author

RussKie commented May 2, 2025

@radical this is ready to be merged.

@RussKie RussKie enabled auto-merge (squash) May 2, 2025 05:46
@RussKie RussKie mentioned this pull request May 2, 2025
Merged
16 tasks
@RussKie RussKie force-pushed the igveliko/reinstate_snapshots branch 2 times, most recently from 20b01f1 to f4405e1 Compare May 5, 2025 01:27
RussKie added 2 commits May 5, 2025 12:22
@RussKie
Reinstate snapshot-based testing
b22f81b 
This reverts commit 8b01c53.

* Reinstate "Use snapshot-based testing (#8930)"
* Reinstate "Convert tests to snapshot-based tests (#9009)"
@RussKie
Push test snapshots to Helix
cbbb6e9
@RussKie RussKie force-pushed the igveliko/reinstate_snapshots branch from f4405e1 to cbbb6e9 Compare May 5, 2025 02:22
radical added 2 commits May 5, 2025 16:25
@radical
Merge remote-tracking branch 'origin/main' into igveliko/reinstate_sn…
f51ecea 
…apshots

# Conflicts:
#	tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj
#	tests/Aspire.Hosting.Azure.Tests/AzureKeyVaultTests.cs
@radical
adjust new test to use the verifier
00834f6
@radical
Copy link
Member

radical commented May 5, 2025

Fixed the conflicts, and updated the new test to use the verifier.

@radical
Copy link
Member

radical commented May 5, 2025

Adjusted some more new tests. It should be green this time.

@RussKie RussKie merged commit 3122f9b into main May 5, 2025
170 checks passed
@RussKie RussKie deleted the igveliko/reinstate_snapshots branch May 5, 2025 22:11
@RussKie
Copy link
Contributor Author

RussKie commented May 5, 2025

Thank you

@davidfowl
Copy link
Member

davidfowl commented May 5, 2025

We need to update some newly added tests

@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

@eerhardt eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

Assignees

@RussKie RussKie

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tests] Hosting.Azure tests broken after the move to snapshot based tests

4 participants

@RussKie @radical @davidfowl