From 2b1980a6a54500f6a7d7327f7a36ef9419d4455c Mon Sep 17 00:00:00 2001 From: Brennan Date: Thu, 7 Sep 2023 18:38:28 -0700 Subject: [PATCH 1/3] Fix IIS OutOfProc sometimes creating multiple app instances after recycle (#50535) --- .../AspNetCore/applicationmanager.cpp | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/applicationmanager.cpp b/src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/applicationmanager.cpp index 7bc3bd2599dd..1da43e14343a 100644 --- a/src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/applicationmanager.cpp +++ b/src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/applicationmanager.cpp @@ -175,17 +175,20 @@ APPLICATION_MANAGER::RecycleApplicationFromManager( } } } + + // Remove apps after calling shutdown on each of them + // This is exclusive to in-process, as the shutdown of an in-process app recycles + // the entire worker process. + if (m_handlerResolver.GetHostingModel() == APP_HOSTING_MODEL::HOSTING_IN_PROCESS) { SRWExclusiveLock lock(m_srwLock); const std::wstring configurationPath = pszApplicationId; - // Remove apps after calling shutdown on each of them - // This is exclusive to in-process, as the shutdown of an inprocess app recycles - // the entire worker process. auto itr = m_pApplicationInfoHash.begin(); while (itr != m_pApplicationInfoHash.end()) { - if (itr->second != nullptr && itr->second->ConfigurationPathApplies(configurationPath)) + if (itr->second != nullptr && itr->second->ConfigurationPathApplies(configurationPath) + && std::find(applicationsToRecycle.begin(), applicationsToRecycle.end(), itr->second) != applicationsToRecycle.end()) { itr = m_pApplicationInfoHash.erase(itr); } @@ -194,7 +197,7 @@ APPLICATION_MANAGER::RecycleApplicationFromManager( ++itr; } } - } + } // Release Exclusive m_srwLock } CATCH_RETURN() From 237376d05c8e7ce126a231e06d406633ebf2e1ce Mon Sep 17 00:00:00 2001 From: James Newton-King Date: Fri, 8 Sep 2023 11:40:16 +0800 Subject: [PATCH 2/3] Update gRPC packages for .NET 8 templates (#50568) --- eng/Versions.props | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/eng/Versions.props b/eng/Versions.props index ef12b0df1940..4bc542942cdb 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -288,12 +288,12 @@ 2.3.0 6.0.0 2.5.0 - 3.22.0 - 2.52.0 - 2.52.0 - 2.52.0 - 2.52.0 - 2.52.0 + 3.23.1 + 2.57.0 + 2.57.0 + 2.57.0 + 2.57.0 + 2.57.0 2.5.108 2.13.0 2.13.0 From 57bf8d9ba28d13b123296a284ea39975757f55c0 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" <42748379+dotnet-maestro[bot]@users.noreply.github.com> Date: Fri, 8 Sep 2023 14:45:04 +0000 Subject: [PATCH 3/3] Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230907.1 (#50589) [release/8.0] Update dependencies from dotnet/source-build-reference-packages --- eng/Version.Details.xml | 4 ++-- eng/Versions.props | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 67e8157c22a2..f4e3e7a55213 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -334,9 +334,9 @@ 9a1c3e1b7f0c8763d4c96e593961a61a72679a7b - + https://github.com/dotnet/source-build-reference-packages - 75ec14a961f43446d952c64b5b3330df750db54f + 18302345498a62222dd3c236b3d1d140dbaed43d diff --git a/eng/Versions.props b/eng/Versions.props index 4bc542942cdb..ba03c2271518 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -164,7 +164,7 @@ 8.0.0-alpha.1.23456.1 - 8.0.0-alpha.1.23455.3 + 8.0.0-alpha.1.23457.1 2.0.0-beta-23228-03