-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C# 8 Readiness #5092
Comments
Thanks @rynowak. |
Additional note: dotnet/csharplang#1630 (comment) |
Additional note: Need to handle the nonnulltypes feature when things are turned on at the compiler level. In generated code we set bits to Reacting to this could be as simple as adding pragma warnings or changing how certain assignments generate. |
1df8128b877ac9ffec5c7547e84927b0ecbe8c16 |
Are we missing test coverage for some of the lesser features? like range |
I'll add some. |
…verage. - When adding additional C# 8 tests found that we didn't fully support this. - Updated the C# 8.0 test to fully encompass everything C# 8.0. - Added a feature flag to control using variable declaration errors when not top level. - Added using variable declaration specific tests. dotnet/aspnetcore#5092
…verage. - When adding additional C# 8 tests found that we didn't fully support this. - Updated the C# 8.0 test to fully encompass everything C# 8.0. - Added a feature flag to control using variable declaration errors when not top level. - Added using variable declaration specific tests. dotnet/aspnetcore#5092
Good thing you mentioned this. Found that we weren't perfect with using declaration syntax 👏 PR out: dotnet/razor#367 |
…verage. - When adding additional C# 8 tests found that we didn't fully support this. - Updated the C# 8.0 test to fully encompass everything C# 8.0. - Added a feature flag to control using variable declaration errors when not top level. - Added using variable declaration specific tests. dotnet/aspnetcore#5092
…verage. - When adding additional C# 8 tests found that we didn't fully support this. - Updated the C# 8.0 test to fully encompass everything C# 8.0. - Added a feature flag to control using variable declaration errors when not top level. - Added using variable declaration specific tests. dotnet/aspnetcore#5092
Done |
We need to evaluate and update Razor for C# 8. This will align with 3.0
https://github.com/dotnet/csharplang/milestone/8
https://channel9.msdn.com/Events/dotnetConf/2018/S103
The text was updated successfully, but these errors were encountered: