From 99f25c4e922e7cc60a2a92d7045ab002a5dbc108 Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Tue, 11 Jun 2019 15:19:32 -0700 Subject: [PATCH 1/7] Add option for only packing specific packages --- .azure/pipelines/ci.yml | 59 +++++++++++------------------------------ Directory.Build.targets | 3 +++ 2 files changed, 19 insertions(+), 43 deletions(-) diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml index 114fd3f1576d..1caba68eb882 100644 --- a/.azure/pipelines/ci.yml +++ b/.azure/pipelines/ci.yml @@ -151,15 +151,12 @@ jobs: buildArgs: -arch arm -NoBuildNodeJS -NoBuildJava + /p:OnlyPackPlatformSpecificPackages=true /p:SignType=$(_SignType) /bl:artifacts/log/build.win-arm.binlog $(_BuildArgs) installNodeJs: false installJdk: false - afterBuild: - # Remove packages that are not rid-specific. - # TODO add a flag so builds only produce runtime packages - - powershell: gci artifacts/packages/ -recurse -exclude 'runtime.*', 'Microsoft.AspNetCore.App.Runtime.*' -file | rm -ea ignore artifacts: - name: Windows_arm_Packages path: artifacts/packages/ @@ -180,14 +177,10 @@ jobs: buildScript: ./eng/scripts/cibuild.sh buildArgs: --no-build-nodejs --no-build-java - /bl:artifacts/log/build.macos.binlog + -p:OnlyPackPlatformSpecificPackages=true + -bl:artifacts/log/build.macos.binlog $(_BuildArgs) installNodeJs: false - afterBuild: - # Remove packages that are not rid-specific. - # TODO add a flag so macOS/Linux builds only produce runtime packages - - script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -not -name 'Microsoft.AspNetCore.App.Runtime.*' -delete; fi - condition: always() artifacts: - name: MacOS_x64_Packages path: artifacts/packages/ @@ -241,17 +234,13 @@ jobs: -e KOREBUILD_SKIP_INSTALL_NETFX=0 \ --no-restore \ --no-build-deps \ - /t:BuildSharedFx \ - /p:BuildRuntimeArchive=false \ - /p:LinuxInstallerType=rpm \ - /bl:artifacts/log/build.rpm.binlog \ + -t:BuildSharedFx \ + -p:OnlyPackPlatformSpecificPackages=true \ + -p:BuildRuntimeArchive=false \ + -p:LinuxInstallerType=rpm \ + -bl:artifacts/log/build.rpm.binlog \ $(_BuildArgs) displayName: Build RPM installers - afterBuild: - # Remove packages that are not rid-specific. - # TODO add a flag so macOS/Linux builds only produce runtime packages - - script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -not -name 'Microsoft.AspNetCore.App.Runtime.*' -delete; fi - condition: always() artifacts: - name: Linux_x64_Packages path: artifacts/packages/ @@ -276,14 +265,10 @@ jobs: buildArgs: --arch arm --no-build-nodejs --no-build-java - /bl:artifacts/log/build.linux-arm.binlog + -p:OnlyPackPlatformSpecificPackages=true + -bl:artifacts/log/build.linux-arm.binlog $(_BuildArgs) installNodeJs: false - afterBuild: - # Remove packages that are not rid-specific. - # TODO add a flag so macOS/Linux builds only produce runtime packages - - script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -not -name 'Microsoft.AspNetCore.App.Runtime.*' -delete; fi - condition: always() artifacts: - name: Linux_arm_Packages path: artifacts/packages/ @@ -308,14 +293,10 @@ jobs: buildArgs: --arch arm64 --no-build-nodejs --no-build-java - /bl:artifacts/log/build.arm64.binlog + -p:OnlyPackPlatformSpecificPackages=true + -bl:artifacts/log/build.arm64.binlog $(_BuildArgs) installNodeJs: false - afterBuild: - # Remove packages that are not rid-specific. - # TODO add a flag so macOS/Linux builds only produce runtime packages - - script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -not -name 'Microsoft.AspNetCore.App.Runtime.*' -delete; fi - condition: always() artifacts: - name: Linux_arm64_Packages path: artifacts/packages/ @@ -345,14 +326,10 @@ jobs: --os-name linux-musl --no-build-nodejs --no-build-java - /bl:artifacts/log/build.musl.binlog + -p:OnlyPackPlatformSpecificPackages=true + -bl:artifacts/log/build.musl.binlog $(_BuildArgs) installNodeJs: false - afterBuild: - # Remove packages that are not rid-specific. - # TODO add a flag so macOS/Linux builds only produce runtime packages - - script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -not -name 'Microsoft.AspNetCore.App.Runtime.*' -delete; fi - condition: always() artifacts: - name: Linux_musl_x64_Packages path: artifacts/packages/ @@ -382,14 +359,10 @@ jobs: --os-name linux-musl --no-build-nodejs --no-build-java - /bl:artifacts/log/build.musl.binlog + -p:OnlyPackPlatformSpecificPackages=true + -bl:artifacts/log/build.musl.binlog $(_BuildArgs) installNodeJs: false - afterBuild: - # Remove packages that are not rid-specific. - # TODO add a flag so macOS/Linux builds only produce runtime packages - - script: if [ -d 'artifacts/packages' ]; then find artifacts/packages/ -type f -not -name 'runtime.*' -not -name 'Microsoft.AspNetCore.App.Runtime.*' -delete; fi - condition: always() artifacts: - name: Linux_musl_arm64_Packages path: artifacts/packages/ diff --git a/Directory.Build.targets b/Directory.Build.targets index 925f9c404d37..4ba1299cdf82 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -1,6 +1,9 @@ + + false + - false + false - + $(BuildDependsOn); GeneratePackageConflictManifest; _ResolveTargetingPackContent; @@ -161,7 +161,8 @@ This package is an internal implementation of the .NET Core SDK and is not meant + Outputs="$(ArchiveOutputPath)" + Condition="'$(IsPackable)' == 'true'"> Date: Tue, 11 Jun 2019 17:37:46 -0700 Subject: [PATCH 4/7] fixup! fixup! fixup! Add option for only packing specific packages --- eng/targets/Packaging.targets | 4 ++-- .../src/Microsoft.VisualStudio.BlazorExtension.csproj | 2 +- src/Components/Directory.Build.targets | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/eng/targets/Packaging.targets b/eng/targets/Packaging.targets index a219ffc54ce5..52ef84b0316a 100644 --- a/eng/targets/Packaging.targets +++ b/eng/targets/Packaging.targets @@ -11,9 +11,9 @@ - <_ProjectPathWithVersion Include="$(MSBuildProjectFullPath)" Condition="'$(IsPackable)' == 'true'"> + <_ProjectPathWithVersion Include="$(MSBuildProjectFullPath)"> $(PackageId) - $(PackageVersion) + $(PackageVersion) $(PackageId.Replace('.',''))PackageVersion diff --git a/src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj b/src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj index abc1310fda6e..d7b7d58ec7f6 100644 --- a/src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj +++ b/src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj @@ -52,7 +52,7 @@ true - + <_TemplatePackage Include="$(ArtifactsShippingPackagesDir)Microsoft.AspNetCore.Blazor.Templates.*.nupkg" /> diff --git a/src/Components/Directory.Build.targets b/src/Components/Directory.Build.targets index 2e138a537297..bd6e40582964 100644 --- a/src/Components/Directory.Build.targets +++ b/src/Components/Directory.Build.targets @@ -1,5 +1,5 @@  - + true From 36c8806cee310e785f84c3185ddf7f23d54b2c63 Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Tue, 11 Jun 2019 18:49:19 -0700 Subject: [PATCH 5/7] Remove Microsoft.AspNetCore.Blazor.Templates.dll from the Blazor VSIX --- .../src/Microsoft.VisualStudio.BlazorExtension.csproj | 3 ++- .../src/Microsoft.AspNetCore.Blazor.Templates.csproj | 10 +++++++++- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj b/src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj index d7b7d58ec7f6..5fb085119857 100644 --- a/src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj +++ b/src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj @@ -97,7 +97,8 @@ + Private="false" + Targets="Build;Pack" /> diff --git a/src/Components/Blazor/Templates/src/Microsoft.AspNetCore.Blazor.Templates.csproj b/src/Components/Blazor/Templates/src/Microsoft.AspNetCore.Blazor.Templates.csproj index 26c91bd897aa..b0120ab08ba2 100644 --- a/src/Components/Blazor/Templates/src/Microsoft.AspNetCore.Blazor.Templates.csproj +++ b/src/Components/Blazor/Templates/src/Microsoft.AspNetCore.Blazor.Templates.csproj @@ -1,4 +1,5 @@ - + + netstandard2.0 Microsoft.AspNetCore.Blazor.Templates.nuspec @@ -6,6 +7,9 @@ False False False + false + none + false $(NoWarn);2008 Templates for ASP.NET Core Blazor projects. aspnet;templates;blazor;spa @@ -45,4 +49,8 @@ + + + + From 33d97bbcc6488869ff32f24b984fb8490f578779 Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Tue, 11 Jun 2019 18:58:01 -0700 Subject: [PATCH 6/7] Ensure ANCMSymbols are produced for x86 --- .../Microsoft.AspNetCore.ANCMSymbols.csproj | 21 ++++++++++++------- .../Microsoft.AspNetCore.ANCMSymbols.csproj | 10 --------- ...ft.AspNetCore.ANCMSymbols.netcoreapp3.0.cs | 3 --- 3 files changed, 14 insertions(+), 20 deletions(-) delete mode 100644 src/Servers/IIS/AspNetCoreModuleV2/ref/Microsoft.AspNetCore.ANCMSymbols.csproj delete mode 100644 src/Servers/IIS/AspNetCoreModuleV2/ref/Microsoft.AspNetCore.ANCMSymbols.netcoreapp3.0.cs diff --git a/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj b/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj index 8a17d1970bfa..0c3ebefac7be 100644 --- a/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj +++ b/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj @@ -1,17 +1,23 @@ - + + netcoreapp3.0 + $(MSBuildProjectName).$(TargetRuntimeIdentifier) true $(PackNativeAssets) false runtimes/$(TargetRuntimeIdentifier)/native/ + $(TargetRuntimeIdentifier) + none + false + false + false $(TargetsForTfmSpecificBuildOutput); AddPackNativeComponents - $(MSBuildProjectName).$(TargetRuntimeIdentifier) @@ -22,16 +28,17 @@ - - - + + - - + + + + diff --git a/src/Servers/IIS/AspNetCoreModuleV2/ref/Microsoft.AspNetCore.ANCMSymbols.csproj b/src/Servers/IIS/AspNetCoreModuleV2/ref/Microsoft.AspNetCore.ANCMSymbols.csproj deleted file mode 100644 index 36c3a47a9afd..000000000000 --- a/src/Servers/IIS/AspNetCoreModuleV2/ref/Microsoft.AspNetCore.ANCMSymbols.csproj +++ /dev/null @@ -1,10 +0,0 @@ - - - - netcoreapp3.0 - - - - - - diff --git a/src/Servers/IIS/AspNetCoreModuleV2/ref/Microsoft.AspNetCore.ANCMSymbols.netcoreapp3.0.cs b/src/Servers/IIS/AspNetCoreModuleV2/ref/Microsoft.AspNetCore.ANCMSymbols.netcoreapp3.0.cs deleted file mode 100644 index 618082bc4a8a..000000000000 --- a/src/Servers/IIS/AspNetCoreModuleV2/ref/Microsoft.AspNetCore.ANCMSymbols.netcoreapp3.0.cs +++ /dev/null @@ -1,3 +0,0 @@ -// Copyright (c) .NET Foundation. All rights reserved. -// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. - From dd50a972b2e3cb2ed26fd27af4e1866db61658d7 Mon Sep 17 00:00:00 2001 From: Nate McMaster Date: Tue, 11 Jun 2019 20:15:36 -0700 Subject: [PATCH 7/7] fixup! Ensure ANCMSymbols are produced for x86 --- eng/ProjectReferences.props | 1 - .../Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/ProjectReferences.props b/eng/ProjectReferences.props index 4c23cda5ed23..3d9790262636 100644 --- a/eng/ProjectReferences.props +++ b/eng/ProjectReferences.props @@ -52,7 +52,6 @@ - diff --git a/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj b/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj index 0c3ebefac7be..551644156715 100644 --- a/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj +++ b/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj @@ -14,6 +14,7 @@ false false false + false $(TargetsForTfmSpecificBuildOutput); AddPackNativeComponents