Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IConnectionSocketFeature #31588

Merged
merged 18 commits into from
Apr 7, 2021
Merged

Added IConnectionSocketFeature #31588

merged 18 commits into from
Apr 7, 2021

Commits on Mar 10, 2021

  1. Added IConnectionSocketFeature for exposing underlying Socket!

    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 10, 2021
    Configuration menu
    Copy the full SHA
    c232fd1 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2021

  1. Readonly Socket !

    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    8e73961 View commit details
    Browse the repository at this point in the history

  2. Revert "Readonly Socket !" 

    This reverts commit 8e73961.
    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 11, 2021
    Configuration menu
    Copy the full SHA
    09840e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2021

  1. Addressed PR feedback!

    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    b320450 View commit details
    Browse the repository at this point in the history

  2. Cleanup - Unwanted usings

    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    703511e View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2021

  1. Addressed PR feedback. 

    Generated TransportConnection file using CodeGenerator
    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 13, 2021
    Configuration menu
    Copy the full SHA
    e7b6a95 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2021

  1. Addressed PR feedback. 

    Added virutal socket again to SocketConnection.cs
    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    b211ce0 View commit details
    Browse the repository at this point in the history

  2. Addressed PR feedback. 

    Added virtual socket again to SocketConnection.cs
    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    f1f01da View commit details
    Browse the repository at this point in the history

  3. Merge branch 'connection-socket-feature' of https://github.com/MCCshr… 

    …eyas/aspnetcore into connection-socket-feature
    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    67128d2 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2021

  1. Added socket finally! :)

    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    ea59c5b View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. Addressed PR feedback.

    @ShreyasJejurkar
    ShreyasJejurkar committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    4b90693 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2021

  1. Addressed PR feedback.

    @ShreyasJejurkar
    ShreyasJejurkar committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    ad3fe21 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into connection-socket-feature

    @ShreyasJejurkar
    ShreyasJejurkar committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    b045329 View commit details
    Browse the repository at this point in the history

  3. Update TransportConnection.Generated.cs

    @ShreyasJejurkar
    ShreyasJejurkar committed Apr 3, 2021
    Configuration menu
    Copy the full SHA
    2c39ec4 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2021

  1. Merge branch 'connection-socket-feature' of https://github.com/MCCshr… 

    …eyas/aspnetcore into MCCshreyas-connection-socket-feature
    @davidfowl
    davidfowl committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    f58857d View commit details
    Browse the repository at this point in the history

  2. Changes to the IConnectionSocketFeature 

    - Removed the nullable from the Socket property as approved in API review
- Make the IConnectionSocketFeature an additional feature instead of one implemented on the TransportConnection.
- Added a test to verify it works
    @davidfowl
    davidfowl committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    a0faae3 View commit details
    Browse the repository at this point in the history

  3. Small nits

    @davidfowl
    davidfowl committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    69cb814 View commit details
    Browse the repository at this point in the history

  4. Copyright

    @davidfowl
    davidfowl committed Apr 7, 2021
    Configuration menu
    Copy the full SHA
    57b5ef6 View commit details
    Browse the repository at this point in the history