.ConfigureAwait(false) in SignalR client libraries #39728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
approved these changes
Jan 24, 2022
Contributor
pranavkm
left a comment
pranavkm
left a comment
There was a problem hiding this comment.
👍🏽 We should also consider enabling this for things that aren't exclusively ASP.NET Core (e.g. DataProtection, Extensions.Features, JSInterop etc).
|
|
||
| [Theory] | ||
| [MemberData(nameof(TransportTypes))] | ||
| public async Task CanBlockOnAsyncOperationsWithOneAtATimeSynchronizationContext(HttpTransportType transportType) |
Member
There was a problem hiding this comment.
I thought we had tests like this before, but looks like they never got merged 😮
aspnet/SignalR#792
Member
|
Why are we using ConfigureAwait on the server side? |
davidfowl
reviewed
Jan 24, 2022
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jan 24, 2022
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jan 24, 2022
src/SignalR/common/Http.Connections/src/Internal/HttpConnectionDispatcher.cs
Show resolved
Hide resolved
halter73
force-pushed
the
halter73/39626
branch
from
0be456d to
7cfaf05
Compare
Member
Author
Fixed. |
BrennanConroy
approved these changes
Jan 25, 2022
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.ConfigureAwait(false)in SignalR client librariesCA2007(Consider calling ConfigureAwait on the awaited task) for SignalR client libraries and shared librariesForceAsync()in ignalR client libraries and shared librariesForceAsync()could still cause deadlocks of the code using the client tried to block a UI thread (or any one-at-a-timeSynchronizationContext) because internal SignalR logic would try to post back to it.Fixes #39626
Partially addresses #31132