Skip to content

[main] Update dependencies from dotnet/runtime dotnet/efcore #39853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dotnet-maestro merged 16 commits into from
Feb 3, 2022
Merged

[main] Update dependencies from dotnet/runtime dotnet/efcore #39853

dotnet-maestro merged 16 commits into from
Feb 3, 2022

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 29, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/efcore

  • Subscription: 8ce5251e-8269-419d-3b2a-08d8b8050dda
  • Build: 2022020.10
  • Date Produced: February 2, 2022 8:16:15 PM UTC
  • Commit: 0103866b680b626813d0e2a258b62d0551e6fea6
  • Branch: refs/heads/main

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 2022020.1
  • Date Produced: February 2, 2022 11:20:23 AM UTC
  • Commit: 6527b7fe83b95a195615c1081f345b6d34d716e7
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20220…
a174e73 
…128.3

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-preview.2.22078.2 -> To Version 7.0.0-preview.2.22078.3
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner January 29, 2022 00:28
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Jan 29, 2022
ghost
ghost approved these changes Jan 29, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
10b5c18 
…0128.9

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json , System.IO.Pipelines , System.DirectoryServices.Protocols , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.Logging , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , System.Security.Cryptography.Xml , System.Threading.RateLimiting , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController
 From Version 7.0.0-preview.2.22078.1 -> To Version 7.0.0-preview.2.22078.9
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Jan 29, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
ac1e2ae 
…0129.4

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json , System.IO.Pipelines , System.DirectoryServices.Protocols , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.Logging , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , System.Security.Cryptography.Xml , System.Threading.RateLimiting , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController
 From Version 7.0.0-preview.2.22078.1 -> To Version 7.0.0-preview.2.22079.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
802420f 
…0130.2

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json , System.IO.Pipelines , System.DirectoryServices.Protocols , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.Logging , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , System.Security.Cryptography.Xml , System.Threading.RateLimiting , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController
 From Version 7.0.0-preview.2.22078.1 -> To Version 7.0.0-preview.2.22080.2
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20220…
99db95b 
…131.1

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-preview.2.22078.2 -> To Version 7.0.0-preview.2.22081.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Jan 31, 2022
@BrennanConroy
Copy link
Member

BrennanConroy commented Jan 31, 2022

I guess WASM doesn't look at type forwards?

dotnet-maestro bot and others added 3 commits January 31, 2022 22:13
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20220…
a445f6d 
…131.2

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-preview.2.22078.2 -> To Version 7.0.0-preview.2.22081.2
@captainsafia
Update using for X509Certificates
673f063
@captainsafia
Undo usings fix
62fd0bf
dougbu
dougbu reviewed Feb 1, 2022
View reviewed changes
src/ProjectTemplates/Shared/Project.cs
var emptyMigration = @"/// <inheritdoc />
protected override void Up(MigrationBuilder migrationBuilder)
{
Copy link
Contributor

@dougbu dougbu Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: Why are there blank lines between these braces❔ We don't do that in regular code.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022…
3a8641c 
…0131.6

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.DirectoryServices.Protocols , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.Json , System.IO.Pipelines , System.Net.Http.WinHttpHandler , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.Logging , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Threading.RateLimiting , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web
 From Version 7.0.0-preview.2.22078.1 -> To Version 7.0.0-preview.2.22081.6
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Feb 1, 2022
@TanayParikh
Copy link
Contributor

TanayParikh commented Feb 1, 2022 •
edited
Loading

Still encountering same issue unfortunately:

crit: Microsoft.AspNetCore.Components.WebAssembly.Rendering.WebAssemblyRenderer[100]
      Unhandled exception rendering component: Could not load type of field 'Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionOptions:_clientCertificates' (1) due to: Could not resolve type with token 0100004a from typeref (expected class 'System.Security.Cryptography.X509Certificates.X509CertificateCollection' in assembly 'System.Security.Cryptography, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') assembly:System.Security.Cryptography, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:System.Security.Cryptography.X509Certificates.X509CertificateCollection member:(null)
System.TypeLoadException: Could not load type of field 'Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionOptions:_clientCertificates' (1) due to: Could not resolve type with token 0100004a from typeref (expected class 'System.Security.Cryptography.X509Certificates.X509CertificateCollection' in assembly 'System.Security.Cryptography, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') assembly:System.Security.Cryptography, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:System.Security.Cryptography.X509Certificates.X509CertificateCollection member:(null)
   at Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionFactory..ctor(IOptions`1 options, ILoggerFactory loggerFactory)
   at System.Reflection.RuntimeConstructorInfo.InternalInvoke(Object , Span`1 , Boolean )
   at System.Reflection.RuntimeConstructorInfo.Invoke(BindingFlags , Binder , Object[] , CultureInfo )
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitConstructor(ConstructorCallSite , RuntimeResolverContext )
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2[[Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeResolverContext, Microsoft.Extensions.DependencyInjection, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[System.Object, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].VisitCallSiteMain(ServiceCallSite , RuntimeResolverContext )
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitRootCache(ServiceCallSite , RuntimeResolverContext )
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteVisitor`2[[Microsoft.Extensions.DependencyInjection.ServiceLookup.RuntimeResolverContext, Microsoft.Extensions.DependencyInjection, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60],[System.Object, System.Private.CoreLib, Version=7.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].VisitCallSite(ServiceCallSite , RuntimeResolverContext )
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.Res

As Safia pointed out, this is may be due to dotnet/runtime#64307. @bartonjs, @vcsjones do you have any recommendations on resolving this issue so this ingestion may flow through.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2022020
11e6ad0 
.1

Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.DirectoryServices.Protocols , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.Json , System.IO.Pipelines , System.Net.Http.WinHttpHandler , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.Logging , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , System.Security.Cryptography.Xml , System.ServiceProcess.ServiceController , System.Threading.RateLimiting , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web
 From Version 7.0.0-preview.2.22078.1 -> To Version 7.0.0-preview.2.22102.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 2022020…
e0ac343 
….5

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-preview.2.22078.2 -> To Version 7.0.0-preview.2.22102.5
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Feb 2, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 2022020…
cb5ed1b 
….10

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-preview.2.22078.2 -> To Version 7.0.0-preview.2.22102.10
@TanayParikh
Copy link
Contributor

TanayParikh commented Feb 2, 2022

/ping @bartonjs, @vcsjones in case you have any recommendations on resolving this issue based on dotnet/runtime#64307.

@vcsjones
Copy link
Member

vcsjones commented Feb 2, 2022

I agree that PR is likely the cause but I do not understand why it would cause a TypeLoadExcption.

... (expected class 'System.Security.Cryptography.X509Certificates.X509CertificateCollection' in assembly 'System.Security.Cryptography, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') ....

System.Security.Cryptography is the new assembly for X509CertificateCollection. It was moved from System.Security.Cryptography.X509Certificates. A TypeForwardedTo exists in the old assembly to point toward the new one.

Is it just that System.Security.Cryptography is not getting loaded? Does a reference to the new assembly need to be added somewhere?

@BrennanConroy
Copy link
Member

BrennanConroy commented Feb 2, 2022

A TypeForwardedTo exists in the old assembly to point toward the new one.

Do we know if WASM follows type forwards?

@vcsjones
Copy link
Member

vcsjones commented Feb 2, 2022

Do we know if WASM follows type forwards?

I do not know, @lewing?

@lewing
Copy link
Member

lewing commented Feb 2, 2022

It should, could this be reflection and trimming failing for the forwarded type?

cc @lambdageek @marek-safar

@lambdageek
Copy link
Member

lambdageek commented Feb 2, 2022

Is it just that System.Security.Cryptography is not getting loaded? Does a reference to the new assembly need to be added somewhere?

It should, could this be reflection and trimming failing for the forwarded type?

cc @lambdageek @marek-safar

yea I'd check that there's a reference to the new assembly, but otherwise maybe the trimming couldn't figure out that the type is needed and dropped it?

@vcsjones
Copy link
Member

vcsjones commented Feb 2, 2022

Based on this error:

... (expected class 'System.Security.Cryptography.X509Certificates.X509CertificateCollection' in assembly 'System.Security.Cryptography, Version=7.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a') ....

It looks like the type loader is looking in the new assembly and just can't find it. Does that more strongly indicate that X509CertificateCollection was trimmed out?

Is the trimmer aware of TypeForwardedTo (does it even need to be)?

@bartonjs
Copy link
Member

bartonjs commented Feb 2, 2022

I know that the dotnet/runtime projects build with no implicit references, and that manifested in similar looking errors. It's possible that some project or projects just need to add a Reference to System.Security.Cryptography for the typeforward to resolve.

The happy news is we're done with the refactoring now, so it won't break again :)

@TanayParikh
Copy link
Contributor

TanayParikh commented Feb 2, 2022

some project or projects just need to add a Reference to System.Security.Cryptography for the typeforward to resolve.

I believe that'd boil down to:

Based on the failing tests. Trying that now, thanks!

@TanayParikh
Copy link
Contributor

TanayParikh commented Feb 3, 2022

System.Security.Cryptography is the new assembly for X509CertificateCollection.

Has this been published? I'm not seeing it in the dotnet7 nuget feed.

@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner February 3, 2022 00:20
@TanayParikh
Copy link
Contributor

TanayParikh commented Feb 3, 2022 •
edited
Loading

1a22670 adds the new System.Security.Cryptography dependency, but it's failing locally as it isn't found in nuget. (See above)

@bartonjs
Copy link
Member

bartonjs commented Feb 3, 2022

It's part of the shared runtime, not a NuGet package; so presumably part of <MicrosoftNETCoreAppRefVersion>7.0.0-preview.2.22102.1</MicrosoftNETCoreAppRefVersion>

@TanayParikh
Copy link
Contributor

TanayParikh commented Feb 3, 2022

It's part of the shared runtime, not a NuGet package; so presumably part of <MicrosoftNETCoreAppRefVersion>7.0.0-preview.2.22102.1</MicrosoftNETCoreAppRefVersion>

We don't reference this directly. What would this mean for us in Microsoft.AspNetCore.Http.Connections.Client.csproj @dougbu @wtgodbe?

@BrennanConroy
Copy link
Member

BrennanConroy commented Feb 3, 2022

Pranav pointed out a previous issue that was similar to this one in #39294

Updating the SDK locally fixes the test.

@BrennanConroy BrennanConroy force-pushed the darc-main-16ab2935-d071-478c-a9e7-5cefbd6e2865 branch from 1a22670 to 0d109c3 Compare February 3, 2022 05:01
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner February 3, 2022 05:01
BrennanConroy
BrennanConroy reviewed Feb 3, 2022
View reviewed changes
src/Components/Authorization/src/CascadingAuthenticationState.razor
@inject AuthenticationStateProvider AuthenticationStateProvider

<CascadingValue TValue="Task<AuthenticationState>" Value="@_currentAuthenticationStateTask" ChildContent="@ChildContent" />
<CascadingValue TValue="System.Threading.Tasks.Task<AuthenticationState>" Value="@_currentAuthenticationStateTask" ChildContent="@ChildContent" />
Copy link
Member

@BrennanConroy BrennanConroy Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranavkm Here's the issue I mentioned

Copy link
Contributor

@pranavkm pranavkm Feb 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#39950

Copy link
Member

@javiercn javiercn Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fixed now

@dotnet-maestro dotnet-maestro bot merged commit f9de7e4 into main Feb 3, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-16ab2935-d071-478c-a9e7-5cefbd6e2865 branch February 3, 2022 06:42
@ghost ghost added this to the 7.0-preview2 milestone Feb 3, 2022
@wtgodbe
Copy link
Member

wtgodbe commented Feb 3, 2022

This is a common failure class we'll see during active development of a release - when Runtime changes API surface area, we can't ingest that change until we get an SDK with the new surface area (what we're building against has different surface area than what we're running against).

@pranavkm
Copy link
Contributor

pranavkm commented Feb 3, 2022

@wtgodbe Blazor runs against the bundled versions of the browser-wasm runtime pack. Could we update our build infrastructure to also configure that along with the MicrosoftNETCoreAppVersion?

@wtgodbe
Copy link
Member

wtgodbe commented Feb 3, 2022

This is a common failure class we'll see during active development of a release - when Runtime changes API surface area, we can't ingest that change until we get an SDK with the new surface area (what we're building against has different surface area than what we're running against).

My memory is wrong, this is only an issue for projects using the Razor SDK. Regular projects don't hit this because of our workaround where we update the SDK's FrameworkReferences to match the incoming runtime version

@wtgodbe wtgodbe mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiercn javiercn javiercn left review comments

@BrennanConroy BrennanConroy BrennanConroy left review comments

@halter73 halter73 Awaiting requested review from halter73

@Pilchie Pilchie Awaiting requested review from Pilchie

+3 more reviewers

@pranavkm pranavkm pranavkm left review comments

@dougbu dougbu dougbu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼

Projects

None yet

Milestone

7.0-preview2

Development

Successfully merging this pull request may close these issues.