Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set InvariantGlobalization in api template #47066

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Set InvariantGlobalization in api template #47066

merged 2 commits into from
Mar 10, 2023

Commits on Mar 9, 2023

  1. Set InvariantGlobalization in api, webapi, grpc, and worker templates 

    API server applications do not typically need culture aware behavior. A better default is to use invariant globalization mode for API apps.

This allows for the globalization code to be trimmed away, making the final executable size smaller. It also reduces startup and memory consumption because ICU isn't loaded.

This also allows the apps to run with consistent behavior on container images that don't include ICU, making the container image smaller as well.

Fix dotnet#47029
    @eerhardt
    eerhardt committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    f7073d4 View commit details
    Browse the repository at this point in the history

  2. Add template tests to ensure InvariantGlobalization is set.

    @eerhardt
    eerhardt committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    daf3758 View commit details
    Browse the repository at this point in the history