Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting SDK #49709

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Reverting SDK #49709

merged 1 commit into from
Jul 28, 2023

Conversation

sebastienros
Copy link
Member

CI is failing with the new version on ARM

@sebastienros
Reverting SDK
147bdd8 
CI is failing with the new version on ARM
@sebastienros sebastienros requested review from a team and wtgodbe as code owners July 28, 2023 15:26
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 28, 2023
@ghost
Copy link

ghost commented Jul 28, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@sebastienros
Copy link
Member Author

Example failure https://dev.azure.com/dnceng-public/public/_build/results?buildId=355133&view=logs&j=4a1f0fe1-d87a-57fd-c29d-71ea15e38f30&t=e34518a7-7ef2-58fc-776d-024f679b17d8

@eerhardt
Copy link
Member

Can you log an issue on either dotnet/runtime or dotnet/sdk so someone can investigate this?

@sebastienros
Copy link
Member Author

dotnet/runtime#89734

@sebastienros sebastienros mentioned this pull request Jul 28, 2023
Closed
joperezr
joperezr approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround Seb.

@joperezr
Copy link
Member

There is a newer SDK build available now (8.0.100-rc.1.23377.5), but it is from the same day so of course it is very likely going to have the same issue.

@sebastienros sebastienros enabled auto-merge (squash) July 28, 2023 16:31
@sebastienros sebastienros merged commit bf52af4 into main Jul 28, 2023
@sebastienros sebastienros deleted the sebros/sdk branch July 28, 2023 20:48
@ghost ghost added this to the 8.0-rc1 milestone Jul 28, 2023
@pavelsavara pavelsavara mentioned this pull request Jul 30, 2023
Merged
eerhardt added a commit to eerhardt/aspnetcore that referenced this pull request Jul 31, 2023
@eerhardt
Revert "Reverting SDK (dotnet#49709)"
c8fd1cb 
This reverts commit bf52af4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@joperezr joperezr joperezr approved these changes

@eerhardt eerhardt eerhardt approved these changes

@adityamandaleeka adityamandaleeka Awaiting requested review from adityamandaleeka

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
8.0-rc1
Development

Successfully merging this pull request may close these issues.
4 participants
@sebastienros @eerhardt @joperezr @wtgodbe