From d4b02b532c02e4385a57f48df88a7725fd66a84c Mon Sep 17 00:00:00 2001 From: wigodbe Date: Thu, 19 Feb 2026 14:46:49 -0800 Subject: [PATCH 01/15] Add FrameworkReference for non-SharedFx projects with SharedFx refs --- Directory.Build.targets | 1 + eng/targets/ResolveReferences.targets | 33 +++++++++++++++++++++++++++ 2 files changed, 34 insertions(+) diff --git a/Directory.Build.targets b/Directory.Build.targets index 0f6befb10be5..8b1685f8c9ae 100644 --- a/Directory.Build.targets +++ b/Directory.Build.targets @@ -131,6 +131,7 @@ + <_RemovedAspNetKnownFrameworkReference Include="@(KnownFrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App'))" /> diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index 39bfaa0f8d4c..d31c7a052b17 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -149,6 +149,39 @@ Text="Redundant <FrameworkReference>. If you have an explicit item in the project file, you might be able to remove it. Some SDKs, like Microsoft.NET.Sdk.Web, add this implicitly." /> + + + + + + + + + + - - - - - + '@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' == '0'"> - + + + + + + + + + + + + + + + Condition="'@(TransitiveFrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' != '0' AND + '$(UseAspNetCoreSharedRuntime)' != 'true'" > From 514ae405265d10cac1284637511e06270020071f Mon Sep 17 00:00:00 2001 From: wigodbe Date: Tue, 24 Feb 2026 10:55:10 -0800 Subject: [PATCH 06/15] Just to be sure --- eng/targets/ResolveReferences.targets | 1 + 1 file changed, 1 insertion(+) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index 4c4694bc2b28..c4a94058b828 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -180,6 +180,7 @@ From 507615711aa4bbf736dc5bdf81921ba329a6b736 Mon Sep 17 00:00:00 2001 From: wigodbe Date: Tue, 24 Feb 2026 14:40:18 -0800 Subject: [PATCH 07/15] Feedback --- eng/targets/ResolveReferences.targets | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index c4a94058b828..8f55300e6756 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -160,29 +160,22 @@ '@(_FrameworkProjectReference)' != '' AND '@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' == '0'"> - - + + + BeforeTargets="ResolveFrameworkReferences" > - + + Condition="'@(TransitiveFrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' != '0'"> From c642e6b56d98d231ad609b63ab9010ab86967dc1 Mon Sep 17 00:00:00 2001 From: wigodbe Date: Tue, 24 Feb 2026 16:05:35 -0800 Subject: [PATCH 08/15] Fixup --- eng/targets/ResolveReferences.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index 8f55300e6756..30f9d4e1ed58 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -174,7 +174,7 @@ From d9bdb0544f1af186bd6b1b124a8e72919527dbd1 Mon Sep 17 00:00:00 2001 From: wigodbe Date: Tue, 24 Feb 2026 16:30:22 -0800 Subject: [PATCH 09/15] Revert "Fixup" This reverts commit c642e6b56d98d231ad609b63ab9010ab86967dc1. --- eng/targets/ResolveReferences.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index 30f9d4e1ed58..8f55300e6756 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -174,7 +174,7 @@ From 1232509c86796a677f8cfd5d70d1855eee263402 Mon Sep 17 00:00:00 2001 From: wigodbe Date: Tue, 24 Feb 2026 16:30:28 -0800 Subject: [PATCH 10/15] Revert "Feedback" This reverts commit 507615711aa4bbf736dc5bdf81921ba329a6b736. --- eng/targets/ResolveReferences.targets | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index 8f55300e6756..c4a94058b828 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -160,22 +160,29 @@ '@(_FrameworkProjectReference)' != '' AND '@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' == '0'"> - - + + + BeforeTargets="ResolveFrameworkReferences" + Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)' AND + '$(IsPackable)' == 'true' AND + '$(IsAspNetCoreApp)' != 'true' AND + '@(_FrameworkProjectReference)' != '' AND + '@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' != '0'" > - + + AfterTargets="ResolvePackageAssets" + Condition="'@(TransitiveFrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' != '0' AND + '$(UseAspNetCoreSharedRuntime)' != 'true'" > From d180f8a97b1aca1cd96fe7a90ba9c51cb50dde94 Mon Sep 17 00:00:00 2001 From: wigodbe Date: Tue, 24 Feb 2026 19:26:38 -0800 Subject: [PATCH 11/15] Fixup --- eng/targets/ResolveReferences.targets | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index c4a94058b828..f773c63af5e1 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -160,29 +160,22 @@ '@(_FrameworkProjectReference)' != '' AND '@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' == '0'"> - - + + + BeforeTargets="ResolveFrameworkReferences" > - + + Condition="'$(UseAspNetCoreSharedRuntime)' != 'true'" > From 6eeb4973229e41f356f4f7d8bfe8e87f973d64ce Mon Sep 17 00:00:00 2001 From: wigodbe Date: Tue, 24 Feb 2026 20:31:30 -0800 Subject: [PATCH 12/15] Revert "Fixup" This reverts commit d180f8a97b1aca1cd96fe7a90ba9c51cb50dde94. --- eng/targets/ResolveReferences.targets | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index f773c63af5e1..c4a94058b828 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -160,22 +160,29 @@ '@(_FrameworkProjectReference)' != '' AND '@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' == '0'"> - - + + + BeforeTargets="ResolveFrameworkReferences" + Condition="'$(TargetFramework)' == '$(DefaultNetCoreTargetFramework)' AND + '$(IsPackable)' == 'true' AND + '$(IsAspNetCoreApp)' != 'true' AND + '@(_FrameworkProjectReference)' != '' AND + '@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' != '0'" > - + + AfterTargets="ResolvePackageAssets" + Condition="'@(TransitiveFrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' != '0' AND + '$(UseAspNetCoreSharedRuntime)' != 'true'" > From fbd36d54f11c003a677e53c8ae4c4f0b1c2da02a Mon Sep 17 00:00:00 2001 From: wigodbe Date: Tue, 24 Feb 2026 20:33:03 -0800 Subject: [PATCH 13/15] Test --- eng/targets/ResolveReferences.targets | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index c4a94058b828..6f6a72073d71 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -160,7 +160,7 @@ '@(_FrameworkProjectReference)' != '' AND '@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' == '0'"> - + @@ -180,9 +180,7 @@ + Condition="'$(UseAspNetCoreSharedRuntime)' != 'true'" > From 5d85a2bc96128656467ca3cca7955006436a5e78 Mon Sep 17 00:00:00 2001 From: wigodbe Date: Thu, 26 Feb 2026 10:45:20 -0800 Subject: [PATCH 14/15] Get error --- eng/targets/ResolveReferences.targets | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index 6f6a72073d71..c58bef367668 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -161,19 +161,14 @@ '@(FrameworkReference->WithMetadataValue('Identity', 'Microsoft.AspNetCore.App')->Count())' == '0'"> - + + BeforeTargets="ResolveFrameworkReferences" > - + From 79ec500a70fe885670c7d1c251ba53a172f24bf4 Mon Sep 17 00:00:00 2001 From: wigodbe Date: Thu, 26 Feb 2026 13:07:39 -0800 Subject: [PATCH 15/15] Fixup --- eng/targets/ResolveReferences.targets | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eng/targets/ResolveReferences.targets b/eng/targets/ResolveReferences.targets index c58bef367668..1a0ae682b59e 100644 --- a/eng/targets/ResolveReferences.targets +++ b/eng/targets/ResolveReferences.targets @@ -168,7 +168,7 @@ - +