Don't explicitly set ValidationProblemDetails status code #8688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-mvc
khellang
force-pushed
the
simplify-api-behavior-options-setup
branch
from
6d2d27f to
2b6d357
Compare
khellang
force-pushed
the
simplify-api-behavior-options-setup
branch
from
2b6d357 to
7dbd677
Compare
khellang
force-pushed
the
simplify-api-behavior-options-setup
branch
from
7dbd677 to
2bdba2c
Compare
|
This can probably just be closed and rolled into #12298 😊 |
|
This isn't really a problem, it's just some redundant code I saw and thought should be removed 😊 |
|
@khellang while the other PR did not remove this, we do have a way to override the default status. I'm going to err on the side of caution and leave this behavior be :) Thanks for your PR though. |
|
Yeah, I just sent it cause it was explicitly asked for (and this is not about overriding the default status or changing any behavior) 😂 #6145 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #6145 (comment)
Wrapping it in a
BadRequestObjectResultbelow will make sure it has the correct status code set:https://github.com/aspnet/AspNetCore/blob/aa89639d629899985b27b4ad749f707efc8892cd/src/Mvc/Mvc.Core/src/ObjectResult.cs#L61-L64