xplat: Adds FreeBSD support

[ghost]

Refs: dotnet/corefx#2068

R=@stephentoub,@mmitche,@josteink,@janhenke,@ghuntley

[dnfclas]

Hi @jasonwilliams200OK, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

[stephentoub]

Did you build and test this locally to build corefx? The CI system for buildtools only builds it; it doesn't then try to use the newly built build tools to build corefx. We shouldn't take a PR in unless we know we at least haven't broken support for building corefx for the other platforms.

[Priya91]

Agree with @stephentoub, we need to test the latest buildtools with corefx build. Steps to test locally are outlined here

[ghost]

@stephentoub, @Priya91, thanks for the review.

I tested building it on Windows box as per the wiki instructions. On executing "C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86 && build.cmd /p:SkipTests=true (taken from https://github.com/dotnet/dotnet-ci/blob/master/jobs/dotnet_buildtools/config.xml#L52), it chokes with:

CSC : error CS0518: Predefined type 'System.Object' is not defined or imported [C:\Users\Jason\Source\Repos\buildtools\src\xunit.netcore.extensions\xunit.netcore.extensions.csproj]

13 Warning(s)
1 Error(s)

Time Elapsed 00:00:01.81
Build Exit Code = 1

Whereas when I execute only build.cmd (with which it uses VS 2015 RC on my box with both VS2013 and VS2015 installed), it throws 156 Errors. Among others there is this recurring one: "Predefined type 'System.Object' is not defined".

I have ditto result with dotnet:buildtools master branch, which could mean this is unrelated to my changes?

Can you confirm if there no other hack required to make it build?

[mmitche]

I believe this is a result of some newly published packages that are not supported with the current version of dnx. My attempt to upgrade to a newer version yesterday hit a road-block. Can you confirm whether any project.lock.json files got edited when you built using the new tools in corefx?

[ghost]

@mmitche, with current master, it does not edit any lock file when I run:

git clone https://github.com/dotnet/buildtools
cd build tools
"C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\vcvarsall.bat" x86 && build.cmd
:: or
"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x86 && build.cmd

It throws:

CSC : error CS0518: Predefined type 'System.Object' is not defined or imported [C:\Users\Jason\Source\Repos\buildtools\src\xunit.netcore.extensions\xunit.netcore.extensions.csproj]
..
..
13 Warning(s)
1 Error(s)
Time Elapsed 00:00:17.53
Build Exit Code = 1

[saper]

This is what I get trying to build it using MSBuild xplat dotnet/msbuild@dc043c7
using mono master.

https://gist.github.com/ad8e7a7b3eec2159b791

[ghost]

Thanks @saper, @akoeplinger for https://github.com/jasonwilliams200OK/buildtools/pull/1 and confirming it works on FreeBSD and Linux. 👍

[saper]

Only nuget fails with:

Attempting to build package from 'Microsoft.DotNet.BuildTools.nuspec'.
File not found: 'Microsoft.DotNet.Build.Tasks\ECMA.snk'.

most probably a slash problem, because the files are there.

[ghost]

@mmitche, these changes are tested on FreeBSD and Linux.

[mmitche]

LGTM

[mmitche]

I'll publish a new buildtools this afternoon.

[ghost]

Thanks! 👍