This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
CallDescr/TransitionBlock changes for ARM64 calling convention #19344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidwrighton @jashook PTAL. I'll check on the CI results once they're complete. |
| @@ -562,7 +562,7 @@ LEAF_END SinglecastDelegateInvokeStub, _TEXT | |||
| #ifdef FEATURE_COMINTEROP | |||
|
|
|||
| #define ComCallPreStub_FrameSize (SIZEOF__GSCookie + SIZEOF__ComMethodFrame) | |||
| #define ComCallPreStub_FirstStackAdjust (SIZEOF__ArgumentRegisters + 2 * 8) // reg args , fp & lr already pushed | |||
| #define ComCallPreStub_FirstStackAdjust (8 + SIZEOF__ArgumentRegisters + 2 * 8) // x8, reg args , fp & lr already pushed | |||
There was a problem hiding this comment.
You might want to consider changing this to (8 + SIZEOF__ArgumentRegisters + (2 * 8)) in case someone gets clever and decides to "optimize" and converts it to (SIZEOF__ArgumentRegisters + 10 * 8) 😞
jashook
approved these changes
Aug 9, 2018
adityamandaleeka
force-pushed
the
aa64_vm_callconv_changes
branch
from
a2de591 to
c891df0
Compare
|
Looks like Jenkins weather affected a few CI legs. @dotnet-bot test Windows_NT x64 Debug CoreFX Tests |
|
Merging this. The CI failures are unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the padding field in the TransitionBlock before the argument registers so that the stack arguments directly follow the register arguments in the layout of the block.
In addition, the Windows ARM64 varargs calling convention allows an argument to be split such that part of it is in x7 and part of it is on the stack, so the return buffer register has also been separated from the rest of the argument registers.
The rest of the changes are fallout from those two (updating various asm stubs, offsets, etc.).