Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Throw an exception when passing strings by-value as out parameters. #21513

Merged
merged 17 commits into from
Feb 6, 2019
Merged

Throw an exception when passing strings by-value as out parameters. #21513

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0b3fc19
Throw an exception when passing strings by-value as out parameters.
jkoritzinsky Dec 12, 2018
30ee1d9
Fix encoding
jkoritzinsky Dec 12, 2018
1d79848
Don't use override in this PR.
jkoritzinsky Dec 12, 2018
753c5a2
Clean up Marshal_In
jkoritzinsky Dec 13, 2018
bb99d15
Remove extraneous whitespace.
jkoritzinsky Dec 13, 2018
af6fdbb
Fix failing test.
jkoritzinsky Dec 13, 2018
ec54a2c
Merge branch 'block-string-byvalue-out' of https://github.com/jkoritz…
jkoritzinsky Dec 13, 2018
cc62861
Remove out attribute in COM string tests.
jkoritzinsky Dec 13, 2018
0e952f4
Add back attribute and check for exception thow in COM tests.
jkoritzinsky Dec 13, 2018
f9f3753
Add block comment to explain the implementation of Reverse_LPWStr_Out…
jkoritzinsky Dec 13, 2018
1310f7e
Only throw in a CLR->Native marshalling situation.
jkoritzinsky Dec 14, 2018
0b9d310
Fix asserts from changed code-paths used in ILWSTRMarshaler.
jkoritzinsky Dec 14, 2018
51da4a1
Add comment and explicitly load in a null value (instead of leaving i…
jkoritzinsky Dec 14, 2018
7f9b948
Merge branch 'master' of https://github.com/dotnet/coreclr into block…
jkoritzinsky Dec 20, 2018
ff9c023
Merge branch 'master' of https://github.com/dotnet/coreclr into block…
jkoritzinsky Jan 2, 2019
698581d
Merge branch 'master' of https://github.com/dotnet/coreclr into block…
jkoritzinsky Jan 8, 2019
7b7a496
Apply suggestions from code review
janvorli Feb 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/src/Interop/COM/ServerContracts/Server.Contracts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ string Add_BStr(

void Reverse_LPWStr_Out([MarshalAs(UnmanagedType.LPWStr)] string a, [MarshalAs(UnmanagedType.LPWStr)] out string b);

void Reverse_LPWStr_OutAttr([MarshalAs(UnmanagedType.LPWStr)] string a, [Out][MarshalAs(UnmanagedType.LPWStr)] string b);
void Reverse_LPWStr_OutAttr([MarshalAs(UnmanagedType.LPWStr)] string a, [MarshalAs(UnmanagedType.LPWStr)] string b);
jkoritzinsky marked this conversation as resolved.
Show resolved Hide resolved

[return: MarshalAs(UnmanagedType.LPWStr)]
StringBuilder Reverse_SB_LPWStr([MarshalAs(UnmanagedType.LPWStr)] StringBuilder a);
Expand Down