Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Remove old method names from Rune #23938

Merged
stephentoub merged 3 commits into from
Apr 15, 2019
Merged

Remove old method names from Rune #23938

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9475a9
Remove old method names from Rune, reenable suppressed tests
GrabYourPitchforks Apr 12, 2019
8a8d98b
Revert re-enablement of failing ArraySegment tests
GrabYourPitchforks Apr 13, 2019
515b9f4
Merge remote-tracking branch 'origin/master' into update_rune
GrabYourPitchforks Apr 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions src/System.Private.CoreLib/shared/System/Text/Rune.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,46 +663,6 @@ public static OperationStatus DecodeLastFromUtf8(ReadOnlySpan<byte> source, out
}
}

public static OperationStatus DecodeUtf16(ReadOnlySpan<char> utf16Source, out Rune result, out int charsConsumed)
{
// [TODO] This method was renamed to DecodeFromUtf16. We'll leave this copy of
// the method here temporarily so that we don't break corefx consumers
// while the rename takes place.
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319

return DecodeFromUtf16(utf16Source, out result, out charsConsumed);
}

public static OperationStatus DecodeUtf16FromEnd(ReadOnlySpan<char> utf16Source, out Rune result, out int charsConsumed)
{
// [TODO] This method was renamed to DecodeLastFromUtf16. We'll leave this copy of
// the method here temporarily so that we don't break corefx consumers
// while the rename takes place.
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319

return DecodeLastFromUtf16(utf16Source, out result, out charsConsumed);
}

public static OperationStatus DecodeUtf8(ReadOnlySpan<byte> utf8Source, out Rune result, out int bytesConsumed)
{
// [TODO] This method was renamed to DecodeFromUtf8. We'll leave this copy of
// the method here temporarily so that we don't break corefx consumers
// while the rename takes place.
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319

return DecodeFromUtf8(utf8Source, out result, out bytesConsumed);
}

public static OperationStatus DecodeUtf8FromEnd(ReadOnlySpan<byte> utf8Source, out Rune result, out int bytesConsumed)
{
// [TODO] This method was renamed to DecodeLastFromUtf8. We'll leave this copy of
// the method here temporarily so that we don't break corefx consumers
// while the rename takes place.
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319

return DecodeLastFromUtf8(utf8Source, out result, out bytesConsumed);
}

/// <summary>
/// Encodes this <see cref="Rune"/> to a UTF-16 destination buffer.
/// </summary>
Expand Down Expand Up @@ -985,16 +945,6 @@ public bool TryEncodeToUtf16(Span<char> destination, out int charsWritten)
return false;
}

public bool TryEncode(Span<char> destination, out int charsWritten)
{
// [TODO] This method was renamed to TryEncodeToUtf16. We'll leave this copy of
// the method here temporarily so that we don't break corefx consumers
// while the rename takes place.
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319

return TryEncodeToUtf16(destination, out charsWritten);
}

/// <summary>
/// Encodes this <see cref="Rune"/> to a destination buffer as UTF-8 bytes.
/// </summary>
Expand Down Expand Up @@ -1063,16 +1013,6 @@ public bool TryEncodeToUtf8(Span<byte> destination, out int bytesWritten)
return false;
}

public bool TryEncodeToUtf8Bytes(Span<byte> destination, out int bytesWritten)
{
// [TODO] This method was renamed to TryEncodeToUtf8. We'll leave this copy of
// the method here temporarily so that we don't break corefx consumers
// while the rename takes place.
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319

return TryEncodeToUtf8(destination, out bytesWritten);
}

/// <summary>
/// Attempts to get the <see cref="Rune"/> which begins at index <paramref name="index"/> in
/// string <paramref name="input"/>.
Expand Down