From 0f03bbfdaba978e9caff8b175997d896f089bd35 Mon Sep 17 00:00:00 2001 From: Tyler Brinkley Date: Fri, 6 Sep 2019 14:55:31 -0500 Subject: [PATCH 1/2] Make StringComparer.Create throw ArgumentNullException Throws proper exception. --- src/System.Private.CoreLib/shared/System/StringComparer.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/System.Private.CoreLib/shared/System/StringComparer.cs b/src/System.Private.CoreLib/shared/System/StringComparer.cs index 527a452989e8..8d88ccaa9e2b 100644 --- a/src/System.Private.CoreLib/shared/System/StringComparer.cs +++ b/src/System.Private.CoreLib/shared/System/StringComparer.cs @@ -61,7 +61,7 @@ public static StringComparer Create(CultureInfo culture, CompareOptions options) { if (culture == null) { - throw new ArgumentException(nameof(culture)); + throw new ArgumentNullException(nameof(culture)); } return new CultureAwareComparer(culture, options); From ba61448081e9512e2493ec4ad5514591d3e583a8 Mon Sep 17 00:00:00 2001 From: Tyler Brinkley Date: Mon, 9 Sep 2019 13:55:27 -0500 Subject: [PATCH 2/2] Update CoreFX.issues.rsp --- tests/CoreFX/CoreFX.issues.rsp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/CoreFX/CoreFX.issues.rsp b/tests/CoreFX/CoreFX.issues.rsp index e6f33eba0798..01952f503f06 100644 --- a/tests/CoreFX/CoreFX.issues.rsp +++ b/tests/CoreFX/CoreFX.issues.rsp @@ -79,3 +79,6 @@ # Test failure: https://github.com/dotnet/corefx/issues/39223 -nomethod System.ComponentModel.TypeConverterTests.FontConverterTest.TestConvertFrom + +# Test failure: https://github.com/dotnet/coreclr/pull/26570 +-nomethod System.Tests.StringComparerTests.CreateCultureOptions_InvalidArguments_Throws