Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement escaped-character handling in (Try)GetDateTime(Offset) methods of the Utf8JsonReader #29035

Closed
layomia opened this issue Mar 21, 2019 · 1 comment
Closed

Implement escaped-character handling in (Try)GetDateTime(Offset) methods of the Utf8JsonReader #29035

layomia opened this issue Mar 21, 2019 · 1 comment
Assignees
@layomia
Labels
area-System.Text.Json
Milestone
3.0

Comments

@layomia
Copy link
Contributor

layomia commented Mar 21, 2019

Similar to the implementation for (Try)GetGuid (dotnet/corefx#36122), we want these methods to handle escaped characters.
@layomia layomia self-assigned this Mar 21, 2019
@layomia
Copy link
Contributor Author

layomia commented Mar 25, 2019 •
edited
Loading

Also adding unescaping support for (Try)GetDateTime(Offset), and (Try)GetGuid in JsonElement.

layomia referenced this issue in dotnet/corefx Apr 2, 2019
@layomia
Implement escaped-character handling in Utf8JsonReader and JsonElement (
769c5ac 
#36347)

* Implement escaped-character handling in (Try)GetDateTime(Offset) & (Try)GetGuid in Utf8JsonReader and JsonElement

This addresses https://github.com/dotnet/corefx/issues/36202.

* Address review comments

* Address more comments

* Simplify stackalloc logic

* Update fraction digit cap to 15

* Add (Try)GetGuid to JsonElement

* Address review feedback

* Add FormatException documentation

* Address review feedback

* Address review comments
@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 3.0 milestone Feb 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-System.Text.Json
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@msftgits @layomia