From afeebcd7caa908bbf24333c29162aecd13f40e35 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Mon, 17 Jul 2017 15:30:08 -0400 Subject: [PATCH] Skip assert in Http SSL test on macOS --- .../HttpClientHandlerTest.ServerCertificates.cs | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.ServerCertificates.cs b/src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.ServerCertificates.cs index 1f3a312dc38e..4c2b426e3c93 100644 --- a/src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.ServerCertificates.cs +++ b/src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.ServerCertificates.cs @@ -7,6 +7,7 @@ using System.Linq; using System.Net.Security; using System.Net.Test.Common; +using System.Runtime.InteropServices; using System.Security.Authentication.ExtendedProtection; using System.Security.Cryptography.X509Certificates; using System.Threading.Tasks; @@ -157,7 +158,12 @@ public async Task UseCallback_ValidCertificate_ExpectedValuesDuringCallback(Uri Assert.NotNull(request); X509ChainStatusFlags flags = chain.ChainStatus.Aggregate(X509ChainStatusFlags.NoError, (cur, status) => cur | status.Status); - Assert.True(errors == SslPolicyErrors.None, $"Expected {SslPolicyErrors.None}, got {errors} with chain status {flags}"); + bool ignoreErrors = // https://github.com/dotnet/corefx/issues/21922#issuecomment-315555237 + RuntimeInformation.IsOSPlatform(OSPlatform.OSX) && + checkRevocation && + errors == SslPolicyErrors.RemoteCertificateChainErrors && + flags == X509ChainStatusFlags.RevocationStatusUnknown; + Assert.True(ignoreErrors || errors == SslPolicyErrors.None, $"Expected {SslPolicyErrors.None}, got {errors} with chain status {flags}"); Assert.True(chain.ChainElements.Count > 0); Assert.NotEmpty(cert.Subject);