Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-02521-03, preview2-26221-06, preview2-26221-05, preview2-26220-02, beta-26221-00, beta-26221-00, respectively (master) #27289
Conversation
|
Still seeing the Alpine 3.6 ILASM failure that we saw in #27212. Still not clear to me what is going wrong... best guess is that TLS is not working properly? |
|
@dotnet/dnceng have we made any changes in the Alpine 3.6 test machines lately? Trying to figure out why ILASM is suddenly failing here. |
|
Pining @dotnet/dncenghot too. |
|
@janvorli created the docker image. Jan do you know if there were any changes to the image? |
|
Discarded CI Status: 5:x: 7:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
243bef7 to
0b3a878
Compare
|
@Chrisboh there were no changes to that image for a couple of months. |
|
@janvorli sounds good. Thanks for taking a look. |
|
Alpine 3.6 Dockerfile is at (https://github.com/dotnet/dotnet-buildtools-prereqs-docker/blob/master/src/alpine/3.6/Dockerfile). Image tag built using this file is |
|
I've confirmed that the TLS model change for the |
|
PR for a fix created: dotnet/coreclr#16461 |
|
Discarded CI Status: 4:x: 1:hourglass: 4:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
0b3a878 to
2c8d26e
Compare
|
Discarded CI Status: 3:x: 4:hourglass: 5:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
2c8d26e to
15a8a28
Compare
|
Discarded CI Status: 1:x: 6:hourglass: 5:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
15a8a28 to
043efc7
Compare
|
Discarded CI Status: 4:x: 1:hourglass: 7:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
043efc7 to
c10ffe0
Compare
|
Discarded CI Status: 1:x: 8:hourglass: 3:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
c10ffe0 to
9ac1154
Compare
|
Discarded CI Status: 5:x: 7:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
9ac1154 to
348264a
Compare
|
Discarded CI Status: 4:x: 2:hourglass: 6:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
348264a to
0e43d1e
Compare
|
Discarded CI Status: 4:x: 8:heavy_check_mark: (click to expand)
|
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
0e43d1e to
ea11563
Compare
|
@Anipik it looks like it was caused by your recent changes from PR dotnet/coreclr#16459. It looks like we are generating a serialized value for b_options now where we didn't used to. |
|
This is from https://github.com/dotnet/coreclr/pull/16334/files#diff-b1ec4f0cf7bf664203932886b2bed94cR193 I think. @Anipik If I understand right, this is a safe diff because you implemented ISerializable. Can you please update the blob and have @ViktorHofer sign off to confirm it's a safe update? Please do this first thing so we can unblock this PR, thanks. |
|
Discarded CI Status: 4:x: 8:heavy_check_mark: (click to expand)
|
…fsTestILC to preview2-02521-03, preview2-26221-06, preview2-26221-05, preview2-26220-02, beta-26221-00, beta-26221-00, respectively
dotnet-maestro-bot
changed the title
dotnet-maestro-bot
force-pushed
the
master-UpdateDependencies
branch
from
ea11563 to
ce01453
Compare
|
@danmosemsft @weshaggard Earlier me and @ahsonkhan added this ahsonkhan/corefx@c1ffef1) to the previous closed PR to fix this failure. The Blob updation PR(#27051 (comment)) needs this pr to get merged for more testing. Should I add this particular commit to this ongoing PR ? |
|
Cherry-picked the change (ahsonkhan/corefx@c1ffef1) to resolve the BinaryFormatterTest failures. |
|
Couldn't update this pull request: Head commit author 'ahsonkhan' is not 'dotnet-maestro-bot' |
While I'm fine with using that to unblock this PR, are we sure that is the correct fix overall though? Are we breaking a real serialization scenario? |
|
Given any break is now already in coreclr, I'm ok with using this baseline update to unblock this PR and following up immediately after. |
…fsTestILC to preview2-02521-03, preview2-26221-06, preview2-26221-05, preview2-26220-02, beta-26221-00, beta-26221-00, respectively (master) (dotnet#27289) * Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-02521-03, preview2-26221-06, preview2-26221-05, preview2-26220-02, beta-26221-00, beta-26221-00, respectively * Fix test data for System.Runtime.Serialization.Formatters BinFormatTestData
…fsTestILC to preview2-02521-03, preview2-26221-06, preview2-26221-05, preview2-26220-02, beta-26221-00, beta-26221-00, respectively (master) (dotnet/corefx#27289) * Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview2-02521-03, preview2-26221-06, preview2-26221-05, preview2-26220-02, beta-26221-00, beta-26221-00, respectively * Fix test data for System.Runtime.Serialization.Formatters BinFormatTestData Commit migrated from dotnet/corefx@c6983b1
10 participants
No description provided.