Adding Microsoft.Bcl.AsyncInterfaces for .NET Standard 2.0 #37189
Conversation
Is this a place-holder name, or is this what @terrajobst has decided on? |
@terrajobst hasn't yet approved this name, this is just what made more sense for now, but I'm happy to change it in the PR if Immo wants to change it. |
|
Just as FYI @terrajobst other one that was considered was Microsoft.Compatibility.AsyncEnumerables |
...rosoft.Compatibility.AsyncInterfaces/ref/Microsoft.Compatibility.AsyncInterfaces.Forwards.cs
Outdated
Show resolved
Hide resolved
|
/cc @KrzysztofCwalina @pakrym as FYI |
There was a problem hiding this comment.
This looks great, thanks @joperezr. I've only marked this as request changes so we don't merge yet. I've set up a meeting to discuss a few architectural items which we need to get clarity on before picking a name here (you're on the invitee list @joperezr).
Basically, we need to differentiate things like immutable which can be evolved (because they can replace the in-box module wholesale) from things like IAE which can't be evolved (becaue they type forward to modules we can't replace).
|
Could we name it somehow that would not scare people? IMO, the ideal name would be System.Extensions.Async (or something like that). Microsoft.Extensions.Async would be acceptable. |
joperezr
added
the
* NO MERGE *
We need to convey that new code doesn’t need these packages ever. They should use the inbox version. The ‘System’ name doesn’t convey this. |
joperezr
removed
the
* NO MERGE *
|
This is now ready to go |
terrajobst
changed the title
…refx#37189) * Adding Microsoft.Compatibility.AsyncInterfaces package * Addressing PR Feedback * Fix small typo * Remove unnecesary configurations from the package * Rename to Microsoft.Bcl.AsyncInterfaces * Addressing PR Feedback Commit migrated from dotnet/corefx@bfcbf22
cc: @stephentoub @ericstj @Petermarcu @maririos @terrajobst
This is adding the package which contains all of the Async interfaces OOB implementation as well as the netcoreapp3.0, uapvnext and netstandard2.1 facades.