Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Fix Timezone Test with Morocco on Windows #37419

Merged
tarekgh merged 1 commit into from
May 6, 2019
Merged

Fix Timezone Test with Morocco on Windows #37419

tarekgh merged 1 commit into from
May 6, 2019

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented May 3, 2019 •
edited
Loading

@tarekgh
Copy link
Member Author

tarekgh commented May 3, 2019

CC @krwq @stephentoub @eanova

@tarekgh tarekgh added this to the 3.0 milestone May 3, 2019
krwq
krwq reviewed May 3, 2019
View reviewed changes
src/System.Runtime/tests/System/TimeZoneInfoTests.cs
string offset = Regex.Match(tzi.DisplayName, @"(-|)[0-9]{2}:[0-9]{2}").Value;
Assert.True(tzi.BaseUtcOffset == TimeSpan.Parse(offset), $"{offset} != {tzi.BaseUtcOffset}, dn:{tzi.DisplayName}, sn:{tzi.DisplayName}");
TimeSpan ts = TimeSpan.Parse(offset);
if (tzi.BaseUtcOffset != ts && tzi.Id.IndexOf("Morocco", StringComparison.Ordinal) >= 0)
Copy link
Member

@krwq krwq May 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there some bug for OS to fix this?

@tarekgh
Copy link
Member Author

tarekgh commented May 3, 2019

please hold and don't merge this. I believe the test should be modified as there is wrong assumption in this test.

@tarekgh tarekgh added * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) and removed * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) labels May 3, 2019
@tarekgh
Copy link
Member Author

tarekgh commented May 6, 2019

Looks the failed test is unrelated and tracked by https://github.com/dotnet/corefx/issues/37370

https://mc.dot.net/#/user/dotnet-bot/pr~2Fdotnet~2Fcorefx~2Frefs~2Fpull~2F37419~2Fmerge/test~2Ffunctional~2Fcli~2F/20190503.31/workItem/System.Net.Ping.Functional.Tests/analysis/xunit/System.Net.NetworkInformation.Tests.PingTest~2FSendPingAsyncWithHostAndTtlAndFragmentPingOptions(fragment:%20False)

System.Net.NetworkInformation.Tests.PingTest

OSX.1012.Amd64.Open-x64-Debug
Get Repro environment
Unhandled Exception of Type Xunit.Sdk.EqualException
Message :
Assert.Equal() Failure
Expected: Success
Actual:   TimedOut
Stack Trace :
   at System.Net.NetworkInformation.Tests.PingTest.PingResultValidator(PingReply pingReply, IPAddress[] localIpAddresses) in /Users/vsts/agent/2.150.3/work/1/s/src/System.Net.Ping/tests/FunctionalTests/PingTest.cs:line 61
   at System.Net.NetworkInformation.Tests.PingTest.<>c__DisplayClass46_0.<SendPingAsyncWithHostAndTtlAndFragmentPingOptions>b__1(PingReply pingReply) in /Users/vsts/agent/2.150.3/work/1/s/src/System.Net.Ping/tests/FunctionalTests/PingTest.cs:line 806
   at System.Net.NetworkInformation.Tests.PingTest.SendPingAsync(Func`2 sendPing, Action`1 pingResultValidator) in /Users/vsts/agent/2.150.3/work/1/s/src/System.Net.Ping/tests/FunctionalTests/PingTest.cs:line 776
   at System.Net.NetworkInformation.Tests.PingTest.SendPingAsyncWithHostAndTtlAndFragmentPingOptions(Boolean fragment) in /Users/vsts/agent/2.150.3/work/1/s/src/System.Net.Ping/tests/FunctionalTests/PingTest.cs:line 802
--- End of stack trace from previous location where exception was thrown ---

@tarekgh tarekgh merged commit 5518ab9 into dotnet:master May 6, 2019
@tarekgh tarekgh deleted the FixMoroccoTZTest branch May 6, 2019 17:18
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
@tarekgh
Fix Timezone Test with Morocco on Windows (dotnet/corefx#37419)
b7510d5 
Commit migrated from dotnet/corefx@5518ab9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@krwq krwq krwq approved these changes

@stephentoub stephentoub stephentoub approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

TimeZoneInfo_DisplayNameStartsWithOffset tes failing locally for Casablanca

3 participants

@tarekgh @krwq @stephentoub