This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update System.Data ownership #41416
Merged
Update System.Data ownership #41416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think so, we can also wait for @ajcvickers (back from vacation in a few days). |
Wraith2
reviewed
Sep 28, 2019
| | [System.Composition](https://github.com/dotnet/corefx/labels/area-System.Composition) | **[@maryamariyan](https://github.com/maryamariyan)**, [@ViktorHofer](https://github.com/ViktorHofer) | | | ||
| | [System.Configuration](https://github.com/dotnet/corefx/labels/area-System.Configuration) | **[@maryamariyan](https://github.com/maryamariyan)**, [@safern](https://github.com/safern) | | | ||
| | [System.Console](https://github.com/dotnet/corefx/labels/area-System.Console) | [@wtgodbe](https://github.com/wtgodbe) | | | ||
| | [System.Data](https://github.com/dotnet/corefx/labels/area-System.Data) | **[@divega](https://github.com/divega)**, [@ajcvickers](https://github.com/ajcvickers),[@cheenamalhotra](https://github.com/cheenamalhotra), [@david-engel](https://github.com/david-engel), [@Gary-Zh ](https://github.com/Gary-Zh) | <ul><li>Odbc, OleDb - [@saurabh](https://github.com/saurabh)</li></ul> | | ||
| | [System.Data](https://github.com/dotnet/corefx/labels/area-System.Data) | [@ajcvickers](https://github.com/ajcvickers),[@cheenamalhotra](https://github.com/cheenamalhotra), [@david-engel](https://github.com/david-engel), [@Gary-Zh ](https://github.com/Gary-Zh) | <ul><li>Odbc, OleDb - [@saurabh](https://github.com/saurabh)</li></ul> | |
There was a problem hiding this comment.
The oledb and odbc needs changing to saurabh500, while Saurabh is a cool guy he's not a Microsoft employee or an expert in data access as far as I know.
There was a problem hiding this comment.
@Wraith2 he is MS employee ;) ... those 2 entries were added per his team request.
There was a problem hiding this comment.
Weird, when i accidentally tagged him a while ago in #37068 (comment) it was the wrong guy
There was a problem hiding this comment.
Ah, we have wrong GH handle here -- it should be @saurabh500
karelz
approved these changes
Sep 30, 2019
|
We can add @roji in separate PR, not blocking on this update. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@9677a14
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@glennc do you know who should be the main owner of System.Data now?
@roji should I add you to the list of owners?