Code review feedback

Author: Mike McLaughlin

src/SOS/SOS.Extensions/MemoryRegionServiceFromDebuggerServices.cs

@@ -13,6 +13,7 @@ namespace SOS.Extensions
 {
     internal sealed class MemoryRegionServiceFromDebuggerServices : IMemoryRegionService
     {
+        private const string AddressCommand = "!address";
         private readonly DebuggerServices _debuggerServices;
 
         public MemoryRegionServiceFromDebuggerServices(DebuggerServices debuggerServices)
@@ -25,7 +26,7 @@ public IEnumerable<IMemoryRegion> EnumerateRegions()
             bool foundHeader = false;
             bool skipped = false;
 
-            ImmutableArray<string> lines = _debuggerServices.ExecuteHostCommand("!address");
+            ImmutableArray<string> lines = _debuggerServices.ExecuteHostCommand(AddressCommand);
             foreach (string line in lines)
             {
                 if (line.Length == 0)
@@ -188,7 +189,7 @@ public IEnumerable<IMemoryRegion> EnumerateRegions()
 
             if (!foundHeader)
             {
-                throw new InvalidOperationException($"!address did not produce a standard header.\nThis may mean symbols could not be resolved for ntdll.\nPlease run !address and make sure the output looks correct.");
+                throw new InvalidOperationException($"{AddressCommand} did not produce a standard header.\nThis may mean symbols could not be resolved for ntdll.\nPlease run {AddressCommand} and make sure the output looks correct.");
             }
         }
 

src/SOS/Strike/clrma/clrma.cpp

@@ -109,9 +109,9 @@ DECLARE_API(clrmaconfig)
         }
     }
 
-    ExtOut("CLRMA logging:              %s\n", g_clrmaGlobalFlags & ClrmaGlobalFlags::LoggingEnabled ? "enabled (disable with '-disable -logging')" : "disabled (enable with '-enable -logging')");
-    ExtOut("CLRMA direct DAC support:   %s\n", g_clrmaGlobalFlags & ClrmaGlobalFlags::DacClrmaEnabled ? "enabled (disable with '-disable -dac')" : "disabled (enable with '-enable -dac')");
-    ExtOut("CLRMA managed support:      %s\n", g_clrmaGlobalFlags & ClrmaGlobalFlags::ManagedClrmaEnabled ? "enabled (disable with '-disable -managed')" : "disabled (enable with '-enable -managed')");
+    ExtOut("CLRMA logging:              %s\n", (g_clrmaGlobalFlags & ClrmaGlobalFlags::LoggingEnabled) ? "enabled (disable with '-disable -logging')" : "disabled (enable with '-enable -logging')");
+    ExtOut("CLRMA direct DAC support:   %s\n", (g_clrmaGlobalFlags & ClrmaGlobalFlags::DacClrmaEnabled) ? "enabled (disable with '-disable -dac')" : "disabled (enable with '-enable -dac')");
+    ExtOut("CLRMA managed support:      %s\n", (g_clrmaGlobalFlags & ClrmaGlobalFlags::ManagedClrmaEnabled) ? "enabled (disable with '-disable -managed')" : "disabled (enable with '-enable -managed')");
 
     return Status;
 }

src/SOS/Strike/clrma/exception.cpp

@@ -92,8 +92,9 @@ ClrmaException::Initialize()
             if (m_exceptionData.Message == 0)
             {
                 // To match the built-in SOS provider that scrapes !pe output.
-                m_message = new (std::nothrow)WCHAR[8];
-                wcscpy(m_message, L"<none>");
+                const WCHAR* none = L"<none>";
+                m_message = new (std::nothrow) WCHAR[wcslen(none) + 1];
+                wcscpy(m_message, none);
             }
             else
             {