-
Notifications
You must be signed in to change notification settings - Fork 382
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Traces generated by collect-linux in #5570 do not collect samples from Microsoft-DotNETCore-SampleProfiler. dotnet-trace convert and dotnet-trace report both generate thread time stacks assuming samples from SampleProfiler
diagnostics/src/Tools/dotnet-trace/TraceFileFormatConverter.cs
Lines 81 to 85 in fcb028b
| SampleProfilerThreadTimeComputer computer = new(eventLog, symbolReader) | |
| { | |
| IncludeEventSourceEvents = false // SpeedScope handles only CPU samples, events are not supported | |
| }; | |
| computer.GenerateThreadTimeStacks(stackSource); |
| SampleProfilerThreadTimeComputer computer = new(eventLog, symbolReader); | |
| computer.GenerateThreadTimeStacks(stackSource); |
Instead, collect-linux can collect thread time perf_event samples with --profile thread-time. So to add support for the new collect-linux traces, convert and report should probably be updated to use https://github.com/microsoft/perfview/blob/main/src/TraceEvent/Computers/ThreadTimeComputer.cs when that's released
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request