Skip to content

[dotnet-trace] Convert and Report not compatible with collect-linux traces #5610

@mdh1418

Description

@mdh1418

Traces generated by collect-linux in #5570 do not collect samples from Microsoft-DotNETCore-SampleProfiler. dotnet-trace convert and dotnet-trace report both generate thread time stacks assuming samples from SampleProfiler

SampleProfilerThreadTimeComputer computer = new(eventLog, symbolReader)
{
IncludeEventSourceEvents = false // SpeedScope handles only CPU samples, events are not supported
};
computer.GenerateThreadTimeStacks(stackSource);
and
SampleProfilerThreadTimeComputer computer = new(eventLog, symbolReader);
computer.GenerateThreadTimeStacks(stackSource);
, so both verbs will result in empty thread time stacks.

Instead, collect-linux can collect thread time perf_event samples with --profile thread-time. So to add support for the new collect-linux traces, convert and report should probably be updated to use https://github.com/microsoft/perfview/blob/main/src/TraceEvent/Computers/ThreadTimeComputer.cs when that's released

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions