Skip to content

Conversation

@Thraka
Copy link
Contributor

@Thraka Thraka commented Apr 11, 2019

Summary

Updated info for what's new based on the blog post.

Fixes #10589

@Thraka Thraka added this to the April 2019 milestone Apr 11, 2019
@Thraka Thraka requested a review from richlander April 11, 2019 21:43
@Thraka Thraka requested a review from rpetrusha as a code owner April 11, 2019 21:43
@mairaw mairaw removed this from the April 2019 milestone Apr 13, 2019
@mairaw
Copy link
Contributor

mairaw commented Apr 13, 2019

removed milestone and project to not double count the same work since you have that on the issue already.

@mairaw mairaw closed this Apr 13, 2019
@mairaw mairaw reopened this Apr 13, 2019
@mairaw
Copy link
Contributor

mairaw commented Apr 13, 2019

Closing and reopening to get rid of the warnings.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good overall @Thraka! Left some comments.

mairaw and others added 13 commits April 15, 2019 08:30
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
@Thraka Thraka requested a review from mairaw April 15, 2019 19:28
@Thraka
Copy link
Contributor Author

Thraka commented Apr 16, 2019

@mairaw This should be good now, can you approve? Thanks!

@mairaw
Copy link
Contributor

mairaw commented Apr 17, 2019

We use the changes-addressed label to flag that the changes are ready for review again. Reviewing now.

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more comments. There are also a few acronyms being used without being defined like GC, BCL, etc. Review where you mention specific Preview releases.

I also think we'll need to simplify this topic a lot. I think we're going into too much detail here in a few cases. In a few areas, we should create the supporting doc and just link to it. For example, for local tools we should do something similar to what we've done for global tools in https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-core-2-1#global-tools.

The .NET ecosystem has relied on [**Json.NET**](https://www.newtonsoft.com/json) and other popular JSON libraries, which continue to be good choices. **Json.NET** uses .NET strings as its base datatype, which are UTF-16 under the hood.
The .NET ecosystem has relied on [**Json.NET**](https://www.newtonsoft.com/json) and other popular JSON libraries, which continue to be good choices. **Json.NET** uses .NET strings as its base datatype, which is UTF-16 under the hood.
The new built-in JSON support is high-performance, low allocation, and based on `Span<byte>`. Three new main JSON-related types have been added to .NET Core 3.0 the `System.Text.Json` namespace.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples should be added to https://github.com/dotnet/samples/tree/master/core/whats-new and have C# and VB versions.

Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
@Thraka
Copy link
Contributor Author

Thraka commented Apr 17, 2019

@mairaw Because of the accelerated timeline (each time a new release comes out and we're behind on getting this updated) I've just been lightly trimming the release notes to put into this article.

Can we merge this as-is and I'll do a FULL review and rewrite? I don't want you wasting your time on this since I still need to do that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What's new for .NET Core 3.0 Preview 3

3 participants