-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Added whats new for core 3 preview 3 #11797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
removed milestone and project to not double count the same work since you have that on the issue already. |
|
Closing and reopening to get rid of the warnings. |
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good overall @Thraka! Left some comments.
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
|
@mairaw This should be good now, can you approve? Thanks! |
|
We use the changes-addressed label to flag that the changes are ready for review again. Reviewing now. |
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments. There are also a few acronyms being used without being defined like GC, BCL, etc. Review where you mention specific Preview releases.
I also think we'll need to simplify this topic a lot. I think we're going into too much detail here in a few cases. In a few areas, we should create the supporting doc and just link to it. For example, for local tools we should do something similar to what we've done for global tools in https://docs.microsoft.com/en-us/dotnet/core/whats-new/dotnet-core-2-1#global-tools.
| The .NET ecosystem has relied on [**Json.NET**](https://www.newtonsoft.com/json) and other popular JSON libraries, which continue to be good choices. **Json.NET** uses .NET strings as its base datatype, which are UTF-16 under the hood. | ||
| The .NET ecosystem has relied on [**Json.NET**](https://www.newtonsoft.com/json) and other popular JSON libraries, which continue to be good choices. **Json.NET** uses .NET strings as its base datatype, which is UTF-16 under the hood. | ||
| The new built-in JSON support is high-performance, low allocation, and based on `Span<byte>`. Three new main JSON-related types have been added to .NET Core 3.0 the `System.Text.Json` namespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
samples should be added to https://github.com/dotnet/samples/tree/master/core/whats-new and have C# and VB versions.
Co-Authored-By: Thraka <2672110+Thraka@users.noreply.github.com>
|
@mairaw Because of the accelerated timeline (each time a new release comes out and we're behind on getting this updated) I've just been lightly trimming the release notes to put into this article. Can we merge this as-is and I'll do a FULL review and rewrite? I don't want you wasting your time on this since I still need to do that 😄 |
Summary
Updated info for what's new based on the blog post.
Fixes #10589