Skip to content

Conversation

@paul1956
Copy link
Contributor

@paul1956 paul1956 commented Sep 6, 2019

Summary

Describe your changes here.
Added Comments after Line Continuation Feature from VB 16, there may be other new feature in VB 16 that I didn't cover.
Fixes #Issue_Number (if available)

@rpetrusha
Copy link
Contributor

@KathleenDollard, could you review this PR?

@rpetrusha rpetrusha added this to the September 2019 milestone Sep 6, 2019
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the documentation, @paul1956. Pending a review from @KathleenDollard, I've left some suggested changes.

Copy link
Contributor

@KathleenDollard KathleenDollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paul1956 Thanks!

I like all of Ron's suggestions.

Paul, can you review the header I added for the line continuation section?

Looks good!

I'll add details of what exactly is added to Core in 16.0 as soon as I can review our final changes and make sure we're done.

paul1956 and others added 9 commits September 6, 2019 17:12
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
…reak-and-combine-statements-in-code.md

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Kathleen Dollard <kathleen.dollard@microsoft.com>
@paul1956
Copy link
Contributor Author

paul1956 commented Sep 7, 2019

@KathleenDollard The file still refers to 15.8 even though there is no such thing and you can't set language version to 15.8, the feature listed there is part of a minor update and is in VB 16.0 Also there is another new visible feature in VB 16.0 UnconstrainedTypeParameterInConditional and it does not appear anywhere and I don't understand it enough to write about it.

@rpetrusha
Copy link
Contributor

@KathleenDollard, we should resolve the issue that @paul1956 is raising about Visual Basic 15.8. Aside from that, the information you've added on Visual Basic 16.0 looks good, @paul1956, so I'll merge your PR now.

@rpetrusha rpetrusha merged commit 88c552f into dotnet:master Sep 10, 2019
@paul1956 paul1956 deleted the VBLineContinuationComment branch September 11, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants