-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add support for Comments after Line Continuations new in VB 16. #14247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@KathleenDollard, could you review this PR? |
rpetrusha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the documentation, @paul1956. Pending a review from @KathleenDollard, I've left some suggested changes.
...ual-basic/programming-guide/program-structure/how-to-break-and-combine-statements-in-code.md
Outdated
Show resolved
Hide resolved
KathleenDollard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paul1956 Thanks!
I like all of Ron's suggestions.
Paul, can you review the header I added for the line continuation section?
Looks good!
I'll add details of what exactly is added to Core in 16.0 as soon as I can review our final changes and make sure we're done.
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
…reak-and-combine-statements-in-code.md Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
Co-Authored-By: Kathleen Dollard <kathleen.dollard@microsoft.com>
|
@KathleenDollard The file still refers to 15.8 even though there is no such thing and you can't set language version to 15.8, the feature listed there is part of a minor update and is in VB 16.0 Also there is another new visible feature in VB 16.0 UnconstrainedTypeParameterInConditional and it does not appear anywhere and I don't understand it enough to write about it. |
|
@KathleenDollard, we should resolve the issue that @paul1956 is raising about Visual Basic 15.8. Aside from that, the information you've added on Visual Basic 16.0 looks good, @paul1956, so I'll merge your PR now. |
Summary
Describe your changes here.
Added Comments after Line Continuation Feature from VB 16, there may be other new feature in VB 16 that I didn't cover.
Fixes #Issue_Number (if available)