From c83de5e8ea60b3fe7906d2a8ff6ae21ca5bd9bf7 Mon Sep 17 00:00:00 2001 From: Mauricio de los Santos Date: Thu, 28 Jun 2018 17:03:17 -0300 Subject: [PATCH 1/2] C26886: Misuse of ` character to create codeboxes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello, @mairaw , Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version. "this bug is affected by a source issue by the ยด character used to create codeboxes" Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR then share your PR number so we can confirm and close this PR. Many thanks in advance. --- docs/framework/wcf/samples/transport-udp.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/framework/wcf/samples/transport-udp.md b/docs/framework/wcf/samples/transport-udp.md index 1d2154ecc31ae..61347cd9f7f70 100644 --- a/docs/framework/wcf/samples/transport-udp.md +++ b/docs/framework/wcf/samples/transport-udp.md @@ -68,7 +68,7 @@ The UDP Transport sample demonstrates how to implement UDP unicast and multicast - The`` class implements and provides a unified base class for and . The class works in conjunction with , which is a base class that implements . -- The`` class implements and and consolidates the `CreateChannel` overloads into one `OnCreateChannel` abstract method. +- The `` class implements `` and `` and consolidates the `CreateChannel` overloads into one `OnCreateChannel` abstract method. - The class implements . It takes care of basic state management. @@ -103,13 +103,13 @@ this.socket.SendTo(messageBuffer.Array, messageBuffer.Offset, messageBuffer.Coun ``` ### The UdpChannelListener - The``UdpChannelListener that the sample implements derives from the class. It uses a single UDP socket to receive datagrams. The `OnOpen` method receives data using the UDP socket in an asynchronous loop. The data are then converted into messages using the Message Encoding Framework. + The `UdpChannelListener` that the sample implements derives from the `` class. It uses a single UDP socket to receive datagrams. The `OnOpen` method receives data using the UDP socket in an asynchronous loop. The data are then converted into messages using the Message Encoding Framework. ```csharp message = MessageEncoderFactory.Encoder.ReadMessage(new ArraySegment(buffer, 0, count), bufferManager); ``` - Because the same datagram channel represents messages that arrive from a number of sources, the `UdpChannelListener` is a singleton listener. There is, at most, one active ``associated with this listener at a time. The sample generates another one only if a channel that is returned by the `AcceptChannel` method is subsequently disposed. When a message is received, it is enqueued into this singleton channel. + Because the same datagram channel represents messages that arrive from a number of sources, the `UdpChannelListener` is a singleton listener. There is, at most, one active `` associated with this listener at a time. The sample generates another one only if a channel that is returned by the `AcceptChannel` method is subsequently disposed. When a message is received, it is enqueued into this singleton channel. #### UdpInputChannel The `UdpInputChannel` class implements `IInputChannel`. It consists of a queue of incoming messages that is populated by the `UdpChannelListener`'s socket. These messages are dequeued by the `IInputChannel.Receive` method. From c70c11bcd04f9a84eb4d5b627ba747423088ca8c Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Thu, 28 Jun 2018 15:20:31 -0700 Subject: [PATCH 2/2] feedback --- docs/framework/wcf/samples/transport-udp.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/framework/wcf/samples/transport-udp.md b/docs/framework/wcf/samples/transport-udp.md index 61347cd9f7f70..9ca70113ce33f 100644 --- a/docs/framework/wcf/samples/transport-udp.md +++ b/docs/framework/wcf/samples/transport-udp.md @@ -66,9 +66,9 @@ The UDP Transport sample demonstrates how to implement UDP unicast and multicast - The class implements and enforces the state machine previously described in Step 2. -- The`` class implements and provides a unified base class for and . The class works in conjunction with , which is a base class that implements . +- The class implements and provides a unified base class for and . The class works in conjunction with , which is a base class that implements . -- The `` class implements `` and `` and consolidates the `CreateChannel` overloads into one `OnCreateChannel` abstract method. +- The class implements and and consolidates the `CreateChannel` overloads into one `OnCreateChannel` abstract method. - The class implements . It takes care of basic state management. @@ -103,13 +103,13 @@ this.socket.SendTo(messageBuffer.Array, messageBuffer.Offset, messageBuffer.Coun ``` ### The UdpChannelListener - The `UdpChannelListener` that the sample implements derives from the `` class. It uses a single UDP socket to receive datagrams. The `OnOpen` method receives data using the UDP socket in an asynchronous loop. The data are then converted into messages using the Message Encoding Framework. + The `UdpChannelListener` that the sample implements derives from the class. It uses a single UDP socket to receive datagrams. The `OnOpen` method receives data using the UDP socket in an asynchronous loop. The data are then converted into messages using the Message Encoding Framework. ```csharp message = MessageEncoderFactory.Encoder.ReadMessage(new ArraySegment(buffer, 0, count), bufferManager); ``` - Because the same datagram channel represents messages that arrive from a number of sources, the `UdpChannelListener` is a singleton listener. There is, at most, one active `` associated with this listener at a time. The sample generates another one only if a channel that is returned by the `AcceptChannel` method is subsequently disposed. When a message is received, it is enqueued into this singleton channel. + Because the same datagram channel represents messages that arrive from a number of sources, the `UdpChannelListener` is a singleton listener. There is, at most, one active associated with this listener at a time. The sample generates another one only if a channel that is returned by the `AcceptChannel` method is subsequently disposed. When a message is received, it is enqueued into this singleton channel. #### UdpInputChannel The `UdpInputChannel` class implements `IInputChannel`. It consists of a queue of incoming messages that is populated by the `UdpChannelListener`'s socket. These messages are dequeued by the `IInputChannel.Receive` method.