Skip to content

Conversation

@mairaw
Copy link
Contributor

@mairaw mairaw commented Jul 31, 2018

Related to #6581

Hide whitespace changes for easier diff

@mairaw mairaw self-assigned this Jul 31, 2018
@mairaw mairaw requested a review from rpetrusha as a code owner July 31, 2018 22:46
Copy link
Contributor

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left two nits, one very minor, @mairaw. You can merge when you're ready.


```csharp
public class CustomEndpoint : ServiceEndpoint
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really a nit (not to mention unrelated to the PR), but the indentation here is troublesome.

Friend Sub New(prefix As String, localname As String, nsURI As String, doc As XmlDocument)
MyBase.New(prefix, localname, nsURI, doc)
CType(doc, LineInfoDocument).IncrementElementCount()
End Sub 'New
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the highlighted characters here. It usually indicates some unusual (non-printing?) character in the file. Here, each of those comments can be removed -- they were auto-generated by the C#-to-VB conversion tool.

@mairaw mairaw merged commit b552544 into dotnet:master Aug 11, 2018
@mairaw mairaw deleted the markdig branch August 11, 2018 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants