Correct occurences of [[...]] #1648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All occurences of [&dotnet#91;...&dotnet#93;] have been correct except: * one occurence in xml\System.Runtime.Remoting.Contexts\IContributeObjectSink.xml as it currently just links to https://docs.microsoft.com/en-us/previous-versions/ * all occurences in xml\System.Xaml\XamlLanguage.xml as these will be corrected in another PR
mikkelbu
commented
Jan 19, 2019
| > [!NOTE] | ||
| > There are two classes named `SynchronizationAttribute` : one in the <xref:System.Runtime.Remoting.Contexts> namespace, and the other in the <xref:System.EnterpriseServices> namespace. The <xref:System.EnterpriseServices.SynchronizationAttribute?displayProperty=nameWithType> class supports only synchronous calls, and can be used only with serviced components. (For more information on serviced components, see [[\<topic://cpconservicedcomponentoverview>]](https://msdn.microsoft.com/library/5133a620-9c8c-47bd-8e36-130e722fe463).) The <xref:System.Runtime.Remoting.Contexts.SynchronizationAttribute?displayProperty=nameWithType> supports both synchronous and asynchronous calls, and can be used only with context bound objects. (For more information on context bound objects, see the <xref:System.ContextBoundObject> class.) | ||
| > There are two classes named `SynchronizationAttribute` : one in the <xref:System.Runtime.Remoting.Contexts> namespace, and the other in the <xref:System.EnterpriseServices> namespace. The <xref:System.EnterpriseServices.SynchronizationAttribute?displayProperty=nameWithType> class supports only synchronous calls, and can be used only with serviced components. (For more information on serviced components, see [Visual Studio 2005 Retired documentation](https://www.microsoft.com/download/details.aspx?id=55984).) The <xref:System.Runtime.Remoting.Contexts.SynchronizationAttribute?displayProperty=nameWithType> supports both synchronous and asynchronous calls, and can be used only with context bound objects. (For more information on context bound objects, see the <xref:System.ContextBoundObject> class.) |
Contributor
Author
There was a problem hiding this comment.
Note that this just points to "Visual Studio 2005 Retired documentation"
mikkelbu
changed the title
mairaw
requested changes
Jan 20, 2019
xml/System.Runtime.Remoting.Contexts/SynchronizationAttribute.xml
Outdated
Show resolved
Hide resolved
Co-Authored-By: mikkelbu <mikkelbu@users.noreply.github.com>
Co-Authored-By: mikkelbu <mikkelbu@users.noreply.github.com>
Co-Authored-By: mikkelbu <mikkelbu@users.noreply.github.com>
Co-Authored-By: mikkelbu <mikkelbu@users.noreply.github.com>
Contributor
Author
|
@mairaw I've applied all the suggestions. |
Contributor
|
I realized I also missed one of your earlier comments. I did find some link targets in previous-versions for that link in IContributeObjectSink but it might be better to just delete that sentence. Would you like to take care of that link here too?
|
Contributor
Author
|
Ok. I've removed the sentence. |
mairaw
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All occurences of
[[...]]have been correct except:as it currently just links to https://docs.microsoft.com/en-us/previous-versions/
all occurences in xml\System.Xaml\XamlLanguage.xmlas these will be corrected in another PR
Edit: The occurences in xml\System.Xaml\XamlLanguage.xml seems fine.
Fixes #1608