From cadab284cf682968913f35b17ec50e3e3593e5db Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Tue, 9 Jun 2020 14:08:13 +0200 Subject: [PATCH 1/6] SslApplicationProtocol: update documention --- .../SslApplicationProtocol.xml | 71 +++++++++++-------- 1 file changed, 42 insertions(+), 29 deletions(-) diff --git a/xml/System.Net.Security/SslApplicationProtocol.xml b/xml/System.Net.Security/SslApplicationProtocol.xml index 4f5ff32d34f..81f4ab474ac 100644 --- a/xml/System.Net.Security/SslApplicationProtocol.xml +++ b/xml/System.Net.Security/SslApplicationProtocol.xml @@ -32,7 +32,7 @@ - To be added. + Represents a values of TLS Application protocol. To be added. @@ -58,8 +58,8 @@ - To be added. - To be added. + TLS Application protocol. + Initializes a new instance of the . To be added. @@ -85,8 +85,8 @@ - To be added. - To be added. + TLS Application protocol. + Initializes a new instance of the . To be added. @@ -118,9 +118,10 @@ - To be added. - To be added. - To be added. + The instance to test for equality. + Compares a to the specified instance. + + if the instance provided has matching data; otherwise, . To be added. @@ -149,9 +150,10 @@ - To be added. - To be added. - To be added. + The object to test for equality. + Compares the to the specified object. + + if is a instance, and the instances have matching data; otherwise, . To be added. @@ -178,8 +180,8 @@ - To be added. - To be added. + Returns the hash code for the instance. + A 32-bit signed integer hash code used to compare instances of this type. To be added. @@ -205,7 +207,9 @@ System.Net.Security.SslApplicationProtocol - To be added. + Gets a representing HTTP/1.1 TLS application protocol. + + representing HTTP/1.1 TLS application protocol. To be added. @@ -231,7 +235,9 @@ System.Net.Security.SslApplicationProtocol - To be added. + Gets a representing HTTP/2 TLS application protocol. + + representing HTTP/2 TLS application protocol. To be added. @@ -254,7 +260,9 @@ System.Net.Security.SslApplicationProtocol - To be added. + Gets a representing HTTP/3 TLS application protocol. + + representing HTTP/3 TLS application protocol. To be added. @@ -284,10 +292,11 @@ - To be added. - To be added. - To be added. - To be added. + The left to an equality operator. + The right to an equality operator. + The equality operator for comparing two objects. + + if the specified and parameters are equal; otherwise, . To be added. @@ -317,10 +326,11 @@ - To be added. - To be added. - To be added. - To be added. + The left to an inequality operator. + The right to an inequality operator. + The inequality operator for comparing two objects. + + if the specified and parameters are inequal; otherwise, . To be added. @@ -346,8 +356,9 @@ System.ReadOnlyMemory<System.Byte> - To be added. - To be added. + >Gets a current TLS application protocol represented by this . + + representing a TLS application protocol. To be added. @@ -374,9 +385,11 @@ - To be added. - To be added. - To be added. + Overrides the method. + Returns a string representation of this object. + + If the contains a valid UTF8 bytes it will retrun text representation othervise hex representation of the value. + From bb832638ca923b3a7e7a5f1bf948c6f383e24c31 Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Wed, 10 Jun 2020 13:28:03 +0200 Subject: [PATCH 2/6] Update xml/System.Net.Security/SslApplicationProtocol.xml Co-authored-by: Maira Wenzel --- xml/System.Net.Security/SslApplicationProtocol.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Net.Security/SslApplicationProtocol.xml b/xml/System.Net.Security/SslApplicationProtocol.xml index 81f4ab474ac..1ac36d8256e 100644 --- a/xml/System.Net.Security/SslApplicationProtocol.xml +++ b/xml/System.Net.Security/SslApplicationProtocol.xml @@ -356,7 +356,7 @@ System.ReadOnlyMemory<System.Byte> - >Gets a current TLS application protocol represented by this . + Gets a current TLS application protocol represented by this . representing a TLS application protocol. To be added. From b84ac7a370ae4ec13a4884f1c962165cbec1316b Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Thu, 11 Jun 2020 13:23:05 +0200 Subject: [PATCH 3/6] Update xml/System.Net.Security/SslApplicationProtocol.xml Co-authored-by: Maira Wenzel --- xml/System.Net.Security/SslApplicationProtocol.xml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/xml/System.Net.Security/SslApplicationProtocol.xml b/xml/System.Net.Security/SslApplicationProtocol.xml index 1ac36d8256e..73347bfc3af 100644 --- a/xml/System.Net.Security/SslApplicationProtocol.xml +++ b/xml/System.Net.Security/SslApplicationProtocol.xml @@ -388,7 +388,13 @@ Overrides the method. Returns a string representation of this object. - If the contains a valid UTF8 bytes it will retrun text representation othervise hex representation of the value. + contains valid UTF-8 bytes, `ToString` returns the text representation of the value; otherwise, the hex representation. + + ]]> From f0f5908028d438247c58a0a88ae911021b9109e8 Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Fri, 12 Jun 2020 10:41:02 +0200 Subject: [PATCH 4/6] Fix see reference --- xml/System.Net.Security/SslApplicationProtocol.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Net.Security/SslApplicationProtocol.xml b/xml/System.Net.Security/SslApplicationProtocol.xml index 73347bfc3af..10c8278341e 100644 --- a/xml/System.Net.Security/SslApplicationProtocol.xml +++ b/xml/System.Net.Security/SslApplicationProtocol.xml @@ -358,7 +358,7 @@ Gets a current TLS application protocol represented by this . - representing a TLS application protocol. + The read-only byte memory representing a TLS application protocol. To be added. From 8c178e9e008fb9b782338432afdf1a9ca8e596de Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Mon, 15 Jun 2020 14:09:19 +0200 Subject: [PATCH 5/6] Add @manickap comments raised in #4367 --- xml/System.Net.Security/SslApplicationProtocol.xml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/xml/System.Net.Security/SslApplicationProtocol.xml b/xml/System.Net.Security/SslApplicationProtocol.xml index 10c8278341e..acbf4c75912 100644 --- a/xml/System.Net.Security/SslApplicationProtocol.xml +++ b/xml/System.Net.Security/SslApplicationProtocol.xml @@ -33,7 +33,16 @@ Represents a values of TLS Application protocol. - To be added. + + values for HTTP versions. + + ]]> + From 96f9e3283f119f5f034c02f6466f5e1182701cfd Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Tue, 16 Jun 2020 10:58:31 +0200 Subject: [PATCH 6/6] Remove space from remarks and --- xml/System.Net.Security/SslApplicationProtocol.xml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xml/System.Net.Security/SslApplicationProtocol.xml b/xml/System.Net.Security/SslApplicationProtocol.xml index acbf4c75912..0a38f24a0de 100644 --- a/xml/System.Net.Security/SslApplicationProtocol.xml +++ b/xml/System.Net.Security/SslApplicationProtocol.xml @@ -37,9 +37,10 @@ values for HTTP versions. +This class contains static field with predefined values for HTTP versions. ]]> @@ -401,7 +402,7 @@ ## Remarks -If the contains valid UTF-8 bytes, `ToString` returns the text representation of the value; otherwise, the hex representation. +If the contains valid UTF-8 bytes, `ToString` returns the text representation of the value; otherwise, the hex representation. ]]>