chore(deps): updated k8s KubernetesClient to v18.0.5 #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated project files to use the latest version of `KubernetesClient` across the solution. - Adjusted `Crds` logic to align with the updated library API.
…thand across tests and core classes - Refactored entity `Metadata` and other class initializations to use object initializer shorthand consistently. - Marked test classes as `sealed` for improved optimization and design clarity. - Adjusted tests and core logic to align with the updated initialization style and coding standards.
- Updated object initializations across generator classes to use initializer shorthand for consistency. - Marked generator classes as `sealed` for optimization and better design practices. - Improved readability and alignment with modern C# coding standards.
…alizer tests - Marked entities (`V1OperatorIntegrationTestEntity` and its sub-classes) and test classes as `sealed` for better design and optimization. - Added null checks in finalizer integration tests to improve safety and adherence to modern C# standards. - Disabled obsolete warning in `KubernetesClient` with a TODO for clarification.
…sts and core classes - Updated object and dictionary initializations to improve readability. - Applied consistent formatting to multiline constructs and private methods. - Improved alignment with modern C# coding style.
- Adjusted formatting in `RbacGenerator` and `NamespacedOperator.Integration.Test` to enhance consistency and readability.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Christoph @buehler ,
I've updated the k8s KubernetesClient to v18 which brings some breaking changes. Unfortunately there is no detailed changelog so I had to extract the changes by comparing v17.0.14 with v18.0.5.
Things to mention are:
Model changed from ctor arguments to property initialization
WatcherExt methods are marked as obsolete - but sadly the message is misleading so I have no idea yet how to replace. I will start a discussion about that with the k8s team. In the meanwhile I disabled the obsolete warning with a pragme which I will remove once I know how to chage it properly. (see: WatcherExt: Watch & WatchAsync marked as obsolete kubernetes-client/csharp#1679)
this will make pull request #967 obsolete