Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit query compilation performance PR after 6.3 #1257

Closed
divega opened this issue Sep 11, 2019 · 1 comment
Closed

Revisit query compilation performance PR after 6.3 #1257

divega opened this issue Sep 11, 2019 · 1 comment

Comments

@divega
Copy link
Contributor

divega commented Sep 11, 2019

We got a PR from @cjpearson in 6.3 that appear to have some significant query compilation performance improvements that could benefit some customers (including @chrfin): #430.

Unfortunately there was a bug discovered in the last minute that forced us to revert in #1251.

This issue is to track revisiting the original PR and try to get it fixed for a later version.

We don't plan to be proactive about this but we will consider contributions.

@chrfin
Copy link
Contributor

chrfin commented Sep 12, 2019

@divega Please take a look at #1239 as I think this fixes the problem and could be merged after 6.3 release to have the improvements back in for the first nightly after the release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants