Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conventions: Internal code usage in provider #11404

Closed
smitpatel opened this issue Mar 23, 2018 · 5 comments
Closed

Conventions: Internal code usage in provider #11404

smitpatel opened this issue Mar 23, 2018 · 5 comments

Comments

@smitpatel
Copy link
Member

At presence when provider has to define their own convention they have to use

  • Define convention using interface from internal, or
  • Define convention by overriding one of the existing EF Convention (ValueGeneration/DbFunction/MaxIdentifierLength)
  • Implementing convention requires access to InternalMetadataBuilder types
  • To register new convention they have to override ConventionSetBuilder & Dependencies (Relational/Core or both)
  • To register convention set builder in DI use IConventionSetBuilder which is also internal

It may also require full access to metadata.

@ajcvickers
Copy link
Member

This is deeply coupled to #214, but rather than closing as a duplicate we are keeping both issues open so that we don't miss that this is an internal code issue for providers, which conceptually could be potentially partly addressed without full public conventions,

@ajcvickers
Copy link
Member

Closing in favor of #214

@ajcvickers
Copy link
Member

Re-opening as a place to track specific data about the internal types still being used:

Annotations Framework

  • InternalEntityTypeBuilder
  • RelationalAnnotationsBuilder
  • ConfigurationSource Public
  • InternalIndexBuilder
  • InternalModelBuilder
  • InternalPropertyBuilder
  • InternalKeyBuilder
  • InternalRelationalBuilder
  • RelationalForeignKeyBuilderAnnotations
  • RelationalPropertyBuilderAnnotations
  • RelationalIndexBuilderAnnotations
  • RelationalKeyBuilderAnnotations
  • RelationalEntityTypeBuilderAnnotations
  • RelationalAnnotationsBuilder
  • Property
  • DbFunction
  • Property
  • EntityType
  • CoreAnnotationNames Public
  • ConventionalAnnotation
  • GetAllBaseTypesInclusive Public
  • FindPrincipal Public
  • FindSharedTableRootPrimaryKeyProperty Public
  • GetDeclaredProperties Public
  • GetDeclaredIndexes Public

Conventions

  • DatabaseGeneratedAttributeConvention
  • IModelInitializedConvention
  • RelationalConventionSetbuilder
  • RelationalConventionSetBuilderDependencies
  • CoreConventionSetBuilder
  • CoreConventionSetBuilderDependencies
  • IConventionSetBuilder
  • RelationalMaxIdentifierLengthConvention
  • RelationalMaxIdentifierLengthConvention
  • RelationalDbFunctionConvention
  • IBaseTypeChangedConvention
  • IIndexAddedConvention
  • IIndexUniquenessChangedConvention
  • IIndexAnnotationChangedConvention
  • IPropertyNullabilityChangedConvention
  • IPropertyAnnotationChangedConvention
  • IEntityTypeAnnotationChangedConvention
  • IKeyAddedConvention
  • RelationalValueGeneratorConvention
  • IModelInitializedConvention
  • ValueGeneratorConvention
  • RelationalDbFunctionConvention

@roji
Copy link
Member

roji commented May 6, 2019

FYI just hit an internal warning on RelationalAnnotationsBuilder (referenced in NpgsqlPropertyBuilderAnnotations, NpgsqlModelBuilderAnnotations) while porting to preview5.

roji added a commit to roji/efcore.pg that referenced this issue May 6, 2019
For usages of RelationalAnnotationsBuilder.
See dotnet/efcore#11404
roji added a commit to roji/efcore.pg that referenced this issue May 6, 2019
For usages of RelationalAnnotationsBuilder.
See dotnet/efcore#11404
@ajcvickers
Copy link
Member

Closing in favor of #15695

@ajcvickers ajcvickers removed this from the 3.0.0 milestone May 13, 2019
@AndriySvyryd AndriySvyryd removed their assignment Mar 6, 2020
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants