Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InMemory: Internal code usage in provider #15096

Closed
ajcvickers opened this issue Mar 21, 2019 · 3 comments
Closed

InMemory: Internal code usage in provider #15096

ajcvickers opened this issue Mar 21, 2019 · 3 comments
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

The in-memory database is currently using:

  • StateManager (Used by seeding)
  • IPrincipalKeyValueFactory (Used by in-memory table)
  • Property.GetIndex()
  • InternalEntityEntry
  • IdentityMapFactoryFactoryBase
  • GetKeyType
@ajcvickers
Copy link
Member Author

Notes from triage: See #15126 for StateManager usage. Other code is pragmatically okay for the in-memory database since we always sim-ship it. We should document this (possibly in analyzer suppressions) so that anyone copying the code has some chance of seeing it.

@ajcvickers ajcvickers added this to the 3.0.0 milestone Mar 22, 2019
@ajcvickers ajcvickers self-assigned this Mar 22, 2019
ajcvickers added a commit that referenced this issue Apr 5, 2019
@ajcvickers
Create a public abstraction for managing seed data
79a0591 
Part of #15096 and #15126

To avoid using the state manager directly.
@ajcvickers
Copy link
Member Author

IQueryBuffer is internal and is used here: https://github.com/aspnet/EntityFrameworkCore/blob/master/src/EFCore.InMemory/Query/Internal/InMemoryQueryContext.cs#L24

ajcvickers added a commit that referenced this issue Apr 8, 2019
@ajcvickers
Create a public abstraction for managing seed data
0233855 
Part of #15096 and #15126

To avoid using the state manager directly.
@ajcvickers ajcvickers mentioned this issue Apr 8, 2019
Merged
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. labels Apr 9, 2019
ajcvickers added a commit that referenced this issue Apr 17, 2019
@ajcvickers
Create a public abstraction for managing seed data
35fb1a9 
Part of #15096 and #15126

To avoid using the state manager directly.
@ajcvickers ajcvickers removed their assignment Apr 17, 2019
ajcvickers added a commit that referenced this issue Apr 17, 2019
@ajcvickers
Create a public abstraction for managing seed data
fb84697 
Part of #15096 and #15126

To avoid using the state manager directly.
@ajcvickers
Copy link
Member Author

Closing in favor of #15695

@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 12, 2019
@smitpatel smitpatel assigned ajcvickers and unassigned smitpatel May 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview6 Jun 5, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview6, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel