Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate internal code usage in Relational #15126

Closed
ajcvickers opened this issue Mar 22, 2019 · 1 comment
Closed

Investigate internal code usage in Relational #15126

ajcvickers opened this issue Mar 22, 2019 · 1 comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Milestone
3.0.0

Comments

@ajcvickers
Copy link
Member

Specifically, look for internal code in Core that is being used in Relational and that all providers are likely to need. This should be made public so that non-relational providers can access it.

For example, there needs to be public API to use the StateManager for seeding.
@ajcvickers ajcvickers mentioned this issue Mar 22, 2019
Closed
@ajcvickers ajcvickers added this to the 3.0.0 milestone Mar 22, 2019
@ajcvickers ajcvickers self-assigned this Mar 22, 2019
ajcvickers added a commit that referenced this issue Apr 5, 2019
@ajcvickers
Create a public abstraction for managing seed data
79a0591 
Part of #15096 and #15126

To avoid using the state manager directly.
ajcvickers added a commit that referenced this issue Apr 8, 2019
@ajcvickers
Create a public abstraction for managing seed data
0233855 
Part of #15096 and #15126

To avoid using the state manager directly.
@ajcvickers ajcvickers mentioned this issue Apr 8, 2019
Merged
ajcvickers added a commit that referenced this issue Apr 17, 2019
@ajcvickers
Create a public abstraction for managing seed data
35fb1a9 
Part of #15096 and #15126

To avoid using the state manager directly.
ajcvickers added a commit that referenced this issue Apr 17, 2019
@ajcvickers
Create a public abstraction for managing seed data
fb84697 
Part of #15096 and #15126

To avoid using the state manager directly.
@ajcvickers
Copy link
Member Author

Done for non-query. Closing in favor of #15695 for remaining work

@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed consider-for-current-release labels May 12, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview6 Jun 5, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview6, 3.0.0 Nov 11, 2019
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. providers-beware type-enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@ajcvickers