Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uniquification of indexes should happen across all tables #15425

Closed
roji opened this issue Apr 20, 2019 · 0 comments · Fixed by #17044
Closed

Uniquification of indexes should happen across all tables #15425

roji opened this issue Apr 20, 2019 · 0 comments · Fixed by #17044
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
3.0.0

Comments

@roji
Copy link
Member

roji commented Apr 20, 2019

Reported in #14055 (comment).

After updating Npgsql to preview4, I get the following test failure:

2019-04-20 14:00:03.826 CEST [6256] npgsql_tests@PartialUpdateNpgsqlTest LOG:  execute <unnamed>: CREATE UNIQUE INDEX "IX_LoginEntityTypeWithAnExtremelyLongAndOverlyConvolutedNameTh~" ON "LoginEntityTypeWithAnExtremelyLongAndOverlyConvolutedNameThat~1" ("ProfileId", "ProfileId1", "ProfileId3", "ProfileId4", "ProfileId5", "ProfileId6", "ProfileId7", "ProfileId8", "ProfileId9", "ProfileId10", "ProfileId11", "ProfileId12", "ProfileId13", "ProfileId14")                                                                                        
2019-04-20 14:00:03.840 CEST [6256] npgsql_tests@PartialUpdateNpgsqlTest LOG:  execute <unnamed>: CREATE INDEX "IX_LoginEntityTypeWithAnExtremelyLongAndOverlyConvolutedNameTh~" ON "LoginEntityTypeWithAnExtremelyLongAndOverlyConvolutedNameThatI~" ("ProfileId", "ProfileId1", "ProfileId3", "ProfileId4", "ProfileId5", "ProfileId6", "ProfileId7", "ProfileId8", "ProfileId9", "ProfileId10", "ProfileId11", "ProfileId12", "ProfileId13", "ProfileId14", "ExtraProperty")                                                                              
2019-04-20 14:00:03.841 CEST [6256] npgsql_tests@PartialUpdateNpgsqlTest ERROR:  relation "IX_LoginEntityTypeWithAnExtremelyLongAndOverlyConvolutedNameTh~" already exists

According to @AndriySvyryd the indexes are being created on different tables, but the uniquification code only looks at the indexes in any single table.
@roji roji mentioned this issue Apr 20, 2019
Closed
@ajcvickers ajcvickers added this to the 3.0.0 milestone Apr 22, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview7 Jul 2, 2019
AndriySvyryd added a commit that referenced this issue Aug 8, 2019
@AndriySvyryd
Uniquify index names across all tables
86705a4 
Fixes #15425
@AndriySvyryd AndriySvyryd mentioned this issue Aug 8, 2019
Merged
AndriySvyryd added a commit that referenced this issue Aug 9, 2019
@AndriySvyryd
Uniquify index names across all tables
7b05462 
Fixes #15425
@AndriySvyryd AndriySvyryd removed their assignment Aug 9, 2019
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 9, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview9 Aug 21, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview9, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Uniquify index names across all tables dotnet/efcore
3 participants
@ajcvickers @roji @AndriySvyryd