Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NotNull attributes to query code #16705

Closed
ajcvickers opened this issue Jul 23, 2019 · 0 comments · Fixed by #19119
Closed

Add NotNull attributes to query code #16705

ajcvickers opened this issue Jul 23, 2019 · 0 comments · Fixed by #19119
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-cleanup
Milestone
5.0.0

Comments

@ajcvickers
Copy link
Member

Breaking out from #15796 since it's not breaking to add these later.
@ajcvickers ajcvickers added this to the Backlog milestone Jul 26, 2019
@ajcvickers ajcvickers self-assigned this Jul 26, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Dec 1, 2019
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Dec 1, 2019
ajcvickers added a commit that referenced this issue Dec 1, 2019
@ajcvickers
Add nullable attributes/parameter checks for query
d47ab37 
Fixes #16705

Attempted to add null checks when the API is a public-surface API, but not for purely internal APIs.

There may be some mistakes here; I plan to do a bit more static analysis after the initial merge.

Also fixed the ApiConsistencyTest to check pubternal types again (not sure why this was removed) and to check protected constructors.
@ajcvickers ajcvickers mentioned this issue Dec 1, 2019
Merged
ajcvickers added a commit that referenced this issue Dec 2, 2019
@ajcvickers
Add nullable attributes/parameter checks for query
f30f7f5 
Fixes #16705

Attempted to add null checks when the API is a public-surface API, but not for purely internal APIs.

There may be some mistakes here; I plan to do a bit more static analysis after the initial merge.

Also fixed the ApiConsistencyTest to check pubternal types again (not sure why this was removed) and to check protected constructors.
ajcvickers added a commit that referenced this issue Dec 8, 2019
@ajcvickers
Add nullable attributes/parameter checks for query
78b0a11 
Fixes #16705

Attempted to add null checks when the API is a public-surface API, but not for purely internal APIs.

There may be some mistakes here; I plan to do a bit more static analysis after the initial merge.

Also fixed the ApiConsistencyTest to check pubternal types again (not sure why this was removed) and to check protected constructors.
ajcvickers added a commit that referenced this issue Dec 8, 2019
@ajcvickers
Add nullable attributes/parameter checks for query
9abd61d 
Fixes #16705

Attempted to add null checks when the API is a public-surface API, but not for purely internal APIs.

There may be some mistakes here; I plan to do a bit more static analysis after the initial merge.

Also fixed the ApiConsistencyTest to check pubternal types again (not sure why this was removed) and to check protected constructors.
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. customer-reported type-cleanup
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Add nullable attributes/parameter checks for query dotnet/efcore
2 participants
@ajcvickers @smitpatel