Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review internal constructors #16708

Closed
ajcvickers opened this issue Jul 23, 2019 · 2 comments
Closed

Review internal constructors #16708

ajcvickers opened this issue Jul 23, 2019 · 2 comments
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Milestone
7.0.0

Comments

@ajcvickers
Copy link
Contributor

Consider making them pubternal.
@ajcvickers ajcvickers added this to the Backlog milestone Jul 26, 2019
@ajcvickers ajcvickers self-assigned this Jul 26, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Nov 25, 2019
@ajcvickers
Copy link
Contributor Author

ajcvickers commented Nov 25, 2019 •
edited
Loading

Also unseal classes as appropriate, See #18936 (review)

@ajcvickers ajcvickers mentioned this issue Nov 25, 2019
Merged
@ajcvickers
Copy link
Contributor Author

ajcvickers commented Jun 7, 2020 •
edited
Loading

  • SqlParameterExpression (Cosmos) - Made pubternal; internal to Cosmos provider anyway.
  • ColumnExpression - has significant functionality that could have bugs; suggest a factory
  • ProjectionExpression - questionable as the wrapper has functionality, but leaving internal for
  • SelectExpression - has significant functionality that could have bugs; suggest a factory
  • SqlParameterExpression - questionable as the wrapper has functionality, but leaving internal for now
  • TableExpression - okay because type is very simple wrapper
  • DbFunctions - appropriate for singleton instance

ajcvickers added a commit that referenced this issue Jun 18, 2020
@ajcvickers
Document some internal constructors
e8497de 
Part of #16708
@ajcvickers ajcvickers mentioned this issue Jun 18, 2020
Merged
ajcvickers added a commit that referenced this issue Jun 19, 2020
@ajcvickers
Document some internal constructors
263b792 
Part of #16708
ajcvickers added a commit that referenced this issue Jun 21, 2020
@ajcvickers
Document some internal constructors
6bd92e5 
Part of #16708
ajcvickers added a commit that referenced this issue Jun 21, 2020
@ajcvickers
Document some internal constructors (#21330)
72f5de1 
Part of #16708
ajcvickers added a commit that referenced this issue Jul 30, 2020
@ajcvickers
Document internal classes are internal for 5.0
7b413a9 
For #16708

What we ultimately do will depend on further discussions after 5.0.
@ajcvickers ajcvickers mentioned this issue Jul 30, 2020
Merged
@ajcvickers ajcvickers modified the milestones: 5.0.0, Backlog Jul 30, 2020
ajcvickers added a commit that referenced this issue Jul 30, 2020
@ajcvickers
Document internal classes are internal for 5.0
1084e09 
For #16708

What we ultimately do will depend on further discussions after 5.0.
ajcvickers added a commit that referenced this issue Jul 30, 2020
@ajcvickers
Document internal classes are internal for 5.0 (#21863)
16420ae 
For #16708

What we ultimately do will depend on further discussions after 5.0.
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Oct 20, 2021
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed consider-for-current-release needs-design labels Oct 20, 2021
@ajcvickers ajcvickers modified the milestones: MQ, 7.0.0 Oct 23, 2021
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview1, 7.0.0 Nov 5, 2022
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-cleanup
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
2 participants
@ajcvickers @smitpatel