Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging to query #17498

Closed
smitpatel opened this issue Aug 29, 2019 · 6 comments · Fixed by #21935
Closed

Add logging to query #17498

smitpatel opened this issue Aug 29, 2019 · 6 comments · Fixed by #21935
Assignees
@smitpatel
Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. poachable punted-for-3.1 type-enhancement
Milestone
5.0.0

Comments

@smitpatel
Copy link
Contributor

smitpatel commented Aug 29, 2019 •
edited
Loading

  • Log for ignored include.
  • Log for including navigation
smitpatel added a commit that referenced this issue Aug 29, 2019
@smitpatel
Update query logging tests
9d8768d 
Filed #17498 to add logging
Resolves #17245
@smitpatel smitpatel mentioned this issue Aug 29, 2019
Merged
smitpatel added a commit that referenced this issue Aug 29, 2019
@smitpatel
Update query logging tests
a45bdb5 
Filed #17498 to add logging
Resolves #17245
smitpatel added a commit that referenced this issue Aug 29, 2019
@smitpatel
Update query logging tests
d4d9b54 
Filed #17498 to add logging
Resolves #17245
@ajcvickers ajcvickers added this to the 3.1.0 milestone Aug 30, 2019
@ajcvickers ajcvickers self-assigned this Aug 30, 2019
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
Update query logging tests
3aa284e 
Filed #17498 to add logging
Resolves #17245
smitpatel added a commit that referenced this issue Sep 3, 2019
@smitpatel
Update query logging tests
a1ae892 
Filed #17498 to add logging
Resolves #17245
@ajcvickers ajcvickers modified the milestones: 3.1.0, Backlog Oct 11, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 5.0.0 Nov 20, 2019
@ajcvickers
Copy link
Contributor

@smitpatel to point to the places where we need to log.

@ajcvickers ajcvickers assigned smitpatel and unassigned smitpatel, roji and ajcvickers Nov 20, 2019
@smitpatel
Copy link
Contributor Author

Also consider #12662

@smitpatel smitpatel mentioned this issue Dec 7, 2019
Closed
@smitpatel
Copy link
Contributor Author

  • Compiling expression tree
  • RowLimitingOperationWithoutOrderByWarning
  • FirstWithoutOrderByAndFilterWarning
  • Optimized expression tree
  • navigation included
  • include ignored
  • Query execution plan, need to print proper plan

@ajcvickers
Copy link
Contributor

Note from team discussion: make sure to add the no-ordering warnings back. They don't need to be provider-specific. See #19331

@ajcvickers ajcvickers mentioned this issue Jan 6, 2020
Closed
@bricelam
Copy link
Contributor

Note from API Review: Re-use the previous EventIds as much as possible

@smitpatel smitpatel mentioned this issue Mar 28, 2020
Closed
@smitpatel
Copy link
Contributor Author

Cleaning up tests which are verifying error messages should be a good start.

smitpatel added a commit that referenced this issue Aug 4, 2020
@smitpatel
Query: Add logging
dd7cf9a 
Part of #17498

Added messages
- Starting query compilation
- Navigation included
- Skip/Take without order by (infra is in core but providers use to generate the warning)
- First without order by or predicate  (infra is in core but providers use to generate the warning)

Removed messages
- Include ignored (they get removed due to automatic pruning based on expression tree visitation
- Obsolete exception with aggregate operator in relational. We logged that when doing client eval of aggregate operation
- Optimized query model - there is no more optimization phase.

Other fixes
- Don't log parameter values in Cosmos when sensitive data logging is not enabled.
@smitpatel smitpatel mentioned this issue Aug 4, 2020
Merged
smitpatel added a commit that referenced this issue Aug 4, 2020
@smitpatel
Query: Add logging
a6acbbb 
Part of #17498

Added messages
- Starting query compilation
- Navigation included
- Skip/Take without order by (infra is in core but providers use to generate the warning)
- First without order by or predicate  (infra is in core but providers use to generate the warning)

Removed messages
- Include ignored (they get removed due to automatic pruning based on expression tree visitation
- Obsolete exception with aggregate operator in relational. We logged that when doing client eval of aggregate operation
- Optimized query model - there is no more optimization phase.

Other fixes
- Don't log parameter values in Cosmos when sensitive data logging is not enabled.
ghost pushed a commit that referenced this issue Aug 4, 2020
@smitpatel
Query: Add logging (#21924)
fb41d0e 
Part of #17498

Added messages
- Starting query compilation
- Navigation included
- Skip/Take without order by (infra is in core but providers use to generate the warning)
- First without order by or predicate  (infra is in core but providers use to generate the warning)

Removed messages
- Include ignored (they get removed due to automatic pruning based on expression tree visitation
- Obsolete exception with aggregate operator in relational. We logged that when doing client eval of aggregate operation
- Optimized query model - there is no more optimization phase.

Other fixes
- Don't log parameter values in Cosmos when sensitive data logging is not enabled.
smitpatel added a commit that referenced this issue Aug 4, 2020
@smitpatel
Query: Add query logger to member/method translators
2344f9f 
Resolves #17498
@smitpatel smitpatel mentioned this issue Aug 4, 2020
Merged
@smitpatel smitpatel modified the milestones: 5.0.0, 5.0.0-rc1 Aug 4, 2020
@smitpatel smitpatel added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 4, 2020
smitpatel added a commit that referenced this issue Aug 4, 2020
@smitpatel
Query: Add query logger to member/method translators
72de0a9 
Resolves #17498
@ghost ghost closed this as completed in #21935 Aug 5, 2020
ghost pushed a commit that referenced this issue Aug 5, 2020
@smitpatel
Query: Add query logger to member/method translators (#21935)
8f7b508 
Resolves #17498
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smitpatel smitpatel

Labels
area-query closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. poachable punted-for-3.1 type-enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Query: Add query logger to member/method translators dotnet/efcore
4 participants
@bricelam @ajcvickers @smitpatel @roji