Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Add more tests for Queryable.Reverse #19356

Closed
smitpatel opened this issue Dec 18, 2019 · 4 comments · Fixed by #26362
Closed

Query: Add more tests for Queryable.Reverse #19356

smitpatel opened this issue Dec 18, 2019 · 4 comments · Fixed by #26362
Assignees
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@smitpatel
Copy link
Member

Add tests for

  • Reverse inside a subquery, i.e. the main query is being pushed down
  • Reverse is used in either side of join/leftjoin/selectmany
  • Reverse is used in a subquery in projection
    • Single result
    • Collection projection
  • Reverse is used in scalar subquery
@smitpatel
Copy link
Member Author

  • OrderBy -> OrderBy -> reverse
  • OrderBy -> ThenBy -> reverse

@Pankraty
Copy link
Contributor

I'll do it if no one minds.

@Pankraty
Copy link
Contributor

@smitpatel I am new to CosmosDB and have some issues so I am asking for a bit of advice.

ss.Set<Employee>()
    .OrderBy(e => e.City)
    .ThenBy(e => e.EmployeeID)
    .Reverse()
    .Select(e => $"{e.EmployeeID}")

this query fails with {"code":400,"body":{"code":"BadRequest","message":"Message: {\"Errors\":[\"The order by query does not have a corresponding composite index that it can be served from.\"]}.

I believe it has to work on CosmosDB too; maybe I have to add a composite index, or choose another pair of columns? Or should I disable that particular test on Cosmos?

@smitpatel
Copy link
Member Author

Disable test on cosmos for now. Issue number in skip message would be #17246

@ajcvickers ajcvickers added this to the Backlog milestone Dec 23, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
@smitpatel smitpatel removed their assignment Feb 12, 2021
maumar added a commit that referenced this issue Oct 15, 2021
Adding tests for thenby, join, subquery, selectmany

Fixes #19356
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2021
maumar added a commit that referenced this issue Oct 15, 2021
Adding tests for thenby, join, subquery, selectmany

Fixes #19356
maumar added a commit that referenced this issue Oct 15, 2021
Adding tests for thenby, join, subquery, selectmany

Fixes #19356
maumar added a commit that referenced this issue Oct 15, 2021
Adding tests for thenby, join, subquery, selectmany

Fixes #19356
@maumar maumar closed this as completed in 33955bf Oct 15, 2021
@maumar maumar modified the milestones: MQ, 7.0.0 Oct 15, 2021
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview1 Feb 14, 2022
@ajcvickers ajcvickers removed this from the 7.0.0-preview1 milestone Nov 5, 2022
@ajcvickers ajcvickers added this to the 7.0.0 milestone Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants