Reverse-Engineer in RC2: Scaffold-DbContext not working on ASP.NET Core project

[rowanmiller]

Found when updating this tutorial https://docs.efproject.net/en/latest/platforms/aspnetcore/existing-db.html

I'm guessing this is an issue in the way we hand off parameters to the CLI command that we shell out to.

PM> Scaffold-DbContext "Server=(localdb)\mssqllocaldb;Database=Blogging;Trusted_Connection=True;" Microsoft.EntityFrameworkCore.SqlServer 
The term 'localdb' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

[natemcmaster]

This is likely a powershell issue. Try using single quotes around the connection string.

[rowanmiller]

Same issue:

PM> Scaffold-DbContext 'Server=(localdb)\mssqllocaldb;Database=Blogging;Trusted_Connection=True;' Microsoft.EntityFrameworkCore.SqlServer
The term 'localdb' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

The exact same format works for a Full .NET Console application

[natemcmaster]

Can you add -Verbose and share the output?

[rowanmiller]

Ah, yep that was helpful, we should quote the connection string when we pass it to dotnet ef.

Working directory: C:\Users\rowmil\Documents\Visual Studio 2015\Projects\EFGetStarted.AspNetCore\src\EFGetStarted.AspNetCore.ExistingDb
Executing command: dotnet ef --configuration Debug --build-base-path .\bin\ dbcontext scaffold Server=(localdb)\mssqllocaldb;Database=Blogging;Trusted_Connection=True; Microsoft.EntityFrameworkCore.SqlServer --verbose
The term 'localdb' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

You can double quote like this and things work.

PM> Scaffold-DbContext "'Server=(localdb)\mssqllocaldb;Database=Blogging;Trusted_Connection=True;'" Microsoft.EntityFrameworkCore.SqlServer -Verbose

[rowanmiller]

We should add quotes when shelling to dotnet ef. Also check for other parameters where this may be an issue (i.e. spaces in output directory).

[natemcmaster]

We do add quotes for spaces. I suppose the fix is to also check for parenthesis.

https://github.com/aspnet/EntityFramework/blob/a065b9377c7f24beb12422b3809002677febe736/src/Microsoft.EntityFrameworkCore.Tools/tools/EntityFramework.psm1#L690

[divega]

Can we just always quote specific arguments?

[natemcmaster]

I don't see why not.

[DamianReeves]

Also it seems that it doesn't like when I pass a connection string with a dash ('-') in it, even with the double quote suggestion.

So running:

Scaffold-DbContext "'server=azuredb-east.database.windows.net;database=dev-azuredb-core;User Id=AzureDbUser;Password=password;Encrypt=True;TrustServerCertificate=False;'" 'Microsoft.EntityFrameworkCore.SqlServer' -Verbose

Yields:

Working directory: C:\code\sandbox\dotnet\AzureDbDataModelConsole\EFGetStarted.AspNetCore.ExistingDb
Executing command: dotnet ef - - c o n f i g u r a t i o n D e b u g - - b u i l d - b a s e - p a t h . \ b i n \ d b c o n t e x t s c a f f o l d ''server=azuredb-east.database.windows.net;database=dev-azuredb-core;User Id=AzureDbUser;Password=password;Encrypt=True;TrustServerCertificate=False;'' M i c r o s o f t . E n t i t y F r a m e w o r k C o r e . S q l S e r v e r - - v e r b o s e
At line:1 char:315
+ ... sword=password;Encrypt=True;TrustServerCertificate=False;'' M i c r o ...
+                                                                 ~
Unexpected token 'M' in expression or statement.

[shrib]

Not sure if this is related, but I get this message in the PMC after installing RC2:
The term 'Scaffold-DbContext' is not recognized as the name of a cmdlet, function, script file, or operable program.