Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: projecting collection navigations using include materialized root entities unnecessarily #8723

Closed
maumar opened this issue Jun 3, 2017 · 1 comment · Fixed by #17805
Closed

Query: projecting collection navigations using include materialized root entities unnecessarily #8723

maumar opened this issue Jun 3, 2017 · 1 comment · Fixed by #17805
Assignees
@maumar
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-2.0 type-bug
Milestone
3.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Jun 3, 2017

Related to #8584 - currently include pipeline requires root object to be materialized always, which results in unnecessary data being pulled when include is used to project collection navigations, e.g.

ctx.Customers.Select(c => c.Detail.Homes)

will materialize customer, details and homes, but ideally we would only materialize homes
@ajcvickers ajcvickers added this to the 2.0.0 milestone Jun 5, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0, Backlog Jun 29, 2017
@smitpatel smitpatel added the verify-fixed This issue is likely fixed in new query pipeline. label Sep 4, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 3.1.0 Sep 4, 2019
@maumar
Copy link
Contributor Author

maumar commented Sep 11, 2019

verified this issue has been fixed in 3.0

@maumar maumar added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed verify-fixed This issue is likely fixed in new query pipeline. labels Sep 11, 2019
@maumar maumar modified the milestones: 3.1.0, 3.0.0 Sep 11, 2019
maumar added a commit that referenced this issue Sep 12, 2019
@maumar
Adding regression tests for issues that have been fixed already
6443c98 
Resolves #8723
Resolves #9241
Resolves #10172
Resolves #10210
Resolves #10548
Resolves #11847
Resolves #11933
Resolves #12741
Resolves #15798
@maumar maumar mentioned this issue Sep 12, 2019
Merged
@maumar maumar closed this as completed in 36a7bdf Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-2.0 type-bug
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Adding regression tests for issues that have been fixed already dotnet/efcore
3 participants
@ajcvickers @smitpatel @maumar