-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo cleanup #16354
typo cleanup #16354
Changes from all commits
042bf67
cc9b072
302b93a
6ccbd4f
43e7545
9ecd34b
9e39395
67c3feb
dcc2135
a32fe81
d4720f1
50db7fa
85386af
fd1b6b1
c8eb794
afd79c4
973c05d
3434362
a68ce48
915e6b5
989ed31
20f2c89
c5d7bb3
2de3271
2aa1ce4
edfa4d2
8d27447
e76663d
4118cf3
a84475e
0560205
305ecd0
6e1ce5f
83d8f1c
83b68b8
bca23a0
565a244
9539cba
0599212
64d1b95
9c73094
58d7c46
3697e68
36e8280
8311fc9
c61bc27
4583a5e
0e9033d
f0f453f
5d244e1
3b18fc8
f943ed7
d04be8b
8a3a6f6
09d86b5
c9edde8
d175cf2
f4f75be
00fa64d
073c7fa
9c0d8c8
2ae3ef4
7a6f478
cdd3c38
f0b8287
d274d07
5c1c161
cbd14ab
d635f82
9223237
f6dd165
632f0ec
dbe8a04
51707a2
b956238
a7e5942
02f4193
5c46673
de99741
e20bfa9
5312d20
830f3f1
1aa3137
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1423,7 +1423,7 @@ protected virtual void CreateTableConstraints( | |
Check.NotNull(operation, nameof(operation)); | ||
Check.NotNull(builder, nameof(builder)); | ||
|
||
CreateTablePrimaryKeyContstraint(operation, model, builder); | ||
CreateTablePrimaryKeyConstraint(operation, model, builder); | ||
CreateTableUniqueConstraints(operation, model, builder); | ||
CreateTableCheckConstraints(operation, model, builder); | ||
CreateTableForeignKeys(operation, model, builder); | ||
|
@@ -1505,7 +1505,7 @@ protected virtual void ForeignKeyConstraint( | |
/// <param name="operation"> The operation. </param> | ||
/// <param name="model"> The target model which may be <c>null</c> if the operations exist without a model. </param> | ||
/// <param name="builder"> The command builder to use to add the SQL fragment. </param> | ||
protected virtual void CreateTablePrimaryKeyContstraint( | ||
protected virtual void CreateTablePrimaryKeyConstraint( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will AspNetCore need to react to this breaking change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It doesn't look like it's referenced there https://github.com/aspnet/AspNetCore/search?q=CreateTablePrimaryKeyContstraint&unscoped_q=CreateTablePrimaryKeyContstraint There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Glad AspNetCore won't need a reaction. This remains a breaking change; renaming a That said, I'm not sure this is announcement-worthy. @ajcvickers your thoughts? |
||
[NotNull] CreateTableOperation operation, | ||
[CanBeNull] IModel model, | ||
[NotNull] MigrationCommandListBuilder builder) | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes under eng/common are irrelevant. If you think this is important, make the changes in the dotnet/arcade repo.