Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrations: Fix bug in complex column ordering code #18196

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Migrations: Fix bug in complex column ordering code #18196

merged 1 commit into from
Oct 7, 2019

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Oct 2, 2019

I knew we'd eventually find weird corner case bugs in this code.

Fixes #14027

@smitpatel
Copy link
Member

Linux failures are weird and not normal cosmos issue it seems.

@AndriySvyryd
Copy link
Member

Also fixes #17773 ?

@bricelam
Copy link
Contributor Author

bricelam commented Oct 4, 2019

@aspnet/efteam @aspnet/build Who broke the Linux build? Is this a known issue?

error NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below: [src/EFCore.Analyzers/EFCore.Analyzers.csproj]
error NU5128: - Add a dependency group for .NETStandard1.3 to the nuspec [src/EFCore.Analyzers/EFCore.Analyzers.csproj]
error NU5128: Some target frameworks declared in the dependencies group of the nuspec and the lib/ref folder do not have exact matches in the other location. Consult the list of actions below: [src/dotnet-ef/dotnet-ef.csproj]
error NU5128: - Add a dependency group for .NETCoreApp2.1 to the nuspec [src/dotnet-ef/dotnet-ef.csproj]

@smitpatel
Copy link
Member

You hit this #18214

But it does not fail for me locally in WSL.

@dougbu
Copy link
Member

dougbu commented Oct 5, 2019

@wtgodbe thought you said the placeholder problems resulted only in warnings? If your placeholder removal is needed here, let's get it into the 'release/3.1' branch.

@bricelam bricelam merged commit 5131e8d into dotnet:release/3.1 Oct 7, 2019
@bricelam bricelam deleted the complex branch October 7, 2019 20:59
@smitpatel
Copy link
Member

@bricelam - What did you do with Linux errors? I hit the same in #18271

@bricelam
Copy link
Contributor Author

bricelam commented Oct 8, 2019

I ignored them. They were clearly unrelated to my changes.

@wtgodbe Should we revert something while you investigate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dotnet ef migrations add produces wrong migration script
4 participants
@bricelam @smitpatel @AndriySvyryd @dougbu