Add nullable attributes/parameter checks for query #19119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
WhoDecidesWhetherItsNotOrNullOrNullOrNotOrNull1128
branch
from
d47ab37
to
f30f7f5
Compare
smitpatel
reviewed
Dec 5, 2019
src/EFCore/Metadata/Conventions/QueryFilterDefiningQueryRewritingConvention.cs
Show resolved
Hide resolved
smitpatel
reviewed
Dec 5, 2019
smitpatel
reviewed
Dec 5, 2019
|
I believe, we can correct anything later if erroneous. |
AndriySvyryd
reviewed
Dec 5, 2019
AndriySvyryd
reviewed
Dec 5, 2019
AndriySvyryd
reviewed
Dec 5, 2019
Fixes #16705 Attempted to add null checks when the API is a public-surface API, but not for purely internal APIs. There may be some mistakes here; I plan to do a bit more static analysis after the initial merge. Also fixed the ApiConsistencyTest to check pubternal types again (not sure why this was removed) and to check protected constructors.
ajcvickers
force-pushed
the
WhoDecidesWhetherItsNotOrNullOrNullOrNotOrNull1128
branch
from
f30f7f5
to
78b0a11
Compare
ajcvickers
deleted the
WhoDecidesWhetherItsNotOrNullOrNullOrNotOrNull1128
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16705
Attempted to add null checks when the API is a public-surface API, but not for purely internal APIs.
There may be some mistakes here; I plan to do a bit more static analysis after the initial merge.
Also fixed the ApiConsistencyTest to check pubternal types again (not sure why this was removed) and to check protected constructors.