[reveng] Move GetModel method into base implementation #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
force-pushed
the
namc/design-2
branch
3 times, most recently
from
38a5faf
to
7d512b9
Compare
| @@ -19,7 +19,7 @@ public class SqliteDesignTimeServices | |||
| public virtual void ConfigureDesignTimeServices([NotNull] IServiceCollection serviceCollection) | |||
| { | |||
| serviceCollection | |||
| .AddSingleton<MetadataModelProvider, SqliteMetadataModelProvider>() | |||
| .AddSingleton<MetadataModelProvider, RelationalMetadataModelProvider>() | |||
There was a problem hiding this comment.
I vaguely remember a discussion on whether provider should still need to derive and have their own implementation (or was it their own interfaces?). Things have been in flux and I can't remember if this ended up being a concern or not. @ajcvickers would know.
There was a problem hiding this comment.
Should we abstract an interface for MetadataModelProvider then?
|
|
LGTM but it would be good if 
|
LGTM too. |
natemcmaster
force-pushed
the
namc/design-2
branch
from
7d512b9
to
fadc2d7
Compare
…Qlite don't both implement the same IMetadataReader => IModel call
natemcmaster
force-pushed
the
namc/design-2
branch
from
fadc2d7
to
1e857bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So SQL Server and SQLite don't both implement the same IMetadataReader => IModel call
/cc @divega @lajones