More precise index scaffolding warning #3989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fine with this. @natemcmaster any comments? |
|
Also fine with this change. @roji can you first cleanup build errors? They are due to remaining references to |
Missing property is only one reason for failing to scaffold an index. Providers may override VisitIndex and return null for other reasons, in which case it's their responsibility to log a warning.
roji
force-pushed
the
index-scaffold-warning
branch
from
965a767
to
503095e
Compare
|
Sorry for taking long with the cleanup, real life gets in the way... I've rebased on dev, corrected the reference and push-forced to this PR. |
|
No worries. That looks good. |
|
@roji Shall I merge it? |
|
@lajones sure thing, unless there are other issues it looks good to me... |
lajones
added a commit
that referenced
this pull request
Dec 9, 2015
More precise index scaffolding warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing property is only one reason for failing to scaffold an index. Providers may override VisitIndex and return null for other reasons, in which case it's their responsibility to log a warning.