-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emulated packs for win-arm64 #231
Conversation
To build arm-64, we need to update this and separate out the manifest packages that flow to VS that supports arm64, then add the necessary metadata, something like <ManifestPackages Include="$(PackageSource)Microsoft.NET.Workload.Mono.ToolChain.6.0-6.0.300.Manifest-*.nupkg" MsiVersion="$(MsiVersion)"/>
<ManifestPackages Include="$(PackageSource)Microsoft.NET.Workload.Mono.ToolChain.6.0-6.0.900*Manifest-*.nupkg" MsiVersion="$(MsiVersion)" SupportsMachineArch="true" /> Also, we need to make sure Arcade/main has all the updates we made in 6.0 and 7.0. I'll check to see if those changes were merged to Arcade/main. |
As it relates to emsdk, what should I put here? The version numbers in your example are tripping me up because they are auto-generated. emsdk/eng/workloads/workloads.csproj Lines 77 to 79 in 52e3130
|
Sorry, the example was a bit contrived. In the release branches we define all the feature bands in eng\versions.props. I was thinking perhaps we add the information explicitly. Again, this is just an example <!-- Expand the items in versions.props -->
<ItemGroup>
<WorkloadSdkBandVersions Include="6.0.100" SupportsMachineArch="true"/>
<WorkloadSdkBandVersions Include="6.0.300" SupportsMachineArch="false"/>
<WorkloadSdkBandVersions Include="6.0.400" SupportsMachineArch="true"/>
</ItemGroup>
<!-- In workload.csproj, include the manifests packages based on the defined feature band versions we get from versions.props, but ignore the runtime version and set the SupportsMachineArch metadata accordingly -->
<Target Name="L">
<ItemGroup>
<F Include="Microsoft.NET.Workload.Emscripten.Manifest-%(WorkloadSdkBandVersions.Identity)" SupportsMachineArch="%(SupportsMachineArch)" />
</ItemGroup>
<Message Text="%(F.Identity), SupportsMachineArch: %(SupportsMachineArch)" />
</Target> |
No description provided.